From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bart Van Assche Subject: Re: [PATCH] scsi/eh: fix hang adding ehandler wakeups after decrementing host_busy Date: Tue, 21 Nov 2017 16:53:18 +0000 Message-ID: <1511283197.2692.13.camel@wdc.com> References: <20170905125424.15412-1-ptikhomirov@virtuozzo.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <20170905125424.15412-1-ptikhomirov@virtuozzo.com> Content-Language: en-US Content-ID: Sender: linux-kernel-owner@vger.kernel.org To: "jejb@linux.vnet.ibm.com" , "ptikhomirov@virtuozzo.com" , "martin.petersen@oracle.com" Cc: "hch@lst.de" , "linux-scsi@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "devel@openvz.org" , "khorenko@virtuozzo.com" List-Id: linux-scsi@vger.kernel.org T24gVHVlLCAyMDE3LTA5LTA1IGF0IDE1OjU0ICswMzAwLCBQYXZlbCBUaWtob21pcm92IHdyb3Rl Og0KPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9zY3NpL3Njc2lfbGliLmMgYi9kcml2ZXJzL3Njc2kv c2NzaV9saWIuYw0KPiBpbmRleCBmNjA5N2I4OWQ1ZDMuLjZjOTkyMjFkNjBhYSAxMDA2NDQNCj4g LS0tIGEvZHJpdmVycy9zY3NpL3Njc2lfbGliLmMNCj4gKysrIGIvZHJpdmVycy9zY3NpL3Njc2lf bGliLmMNCj4gQEAgLTMyMCwxMiArMzIwLDExIEBAIHZvaWQgc2NzaV9kZXZpY2VfdW5idXN5KHN0 cnVjdCBzY3NpX2RldmljZSAqc2RldikNCj4gIAlpZiAoc3RhcmdldC0+Y2FuX3F1ZXVlID4gMCkN Cj4gIAkJYXRvbWljX2RlYygmc3RhcmdldC0+dGFyZ2V0X2J1c3kpOw0KPiAgDQo+ICsJc3Bpbl9s b2NrX2lycXNhdmUoc2hvc3QtPmhvc3RfbG9jaywgZmxhZ3MpOw0KPiAgCWlmICh1bmxpa2VseShz Y3NpX2hvc3RfaW5fcmVjb3Zlcnkoc2hvc3QpICYmDQo+IC0JCSAgICAgKHNob3N0LT5ob3N0X2Zh aWxlZCB8fCBzaG9zdC0+aG9zdF9laF9zY2hlZHVsZWQpKSkgew0KPiAtCQlzcGluX2xvY2tfaXJx c2F2ZShzaG9zdC0+aG9zdF9sb2NrLCBmbGFncyk7DQo+ICsJCSAgICAgKHNob3N0LT5ob3N0X2Zh aWxlZCB8fCBzaG9zdC0+aG9zdF9laF9zY2hlZHVsZWQpKSkNCj4gIAkJc2NzaV9laF93YWtldXAo c2hvc3QpOw0KPiAtCQlzcGluX3VubG9ja19pcnFyZXN0b3JlKHNob3N0LT5ob3N0X2xvY2ssIGZs YWdzKTsNCj4gLQl9DQo+ICsJc3Bpbl91bmxvY2tfaXJxcmVzdG9yZShzaG9zdC0+aG9zdF9sb2Nr LCBmbGFncyk7DQo+ICANCj4gIAlhdG9taWNfZGVjKCZzZGV2LT5kZXZpY2VfYnVzeSk7DQo+ICB9 DQo+IEBAIC0xNTAzLDYgKzE1MDIsMTMgQEAgc3RhdGljIGlubGluZSBpbnQgc2NzaV9ob3N0X3F1 ZXVlX3JlYWR5KHN0cnVjdCByZXF1ZXN0X3F1ZXVlICpxLA0KPiAgCXNwaW5fdW5sb2NrX2lycShz aG9zdC0+aG9zdF9sb2NrKTsNCj4gIG91dF9kZWM6DQo+ICAJYXRvbWljX2RlYygmc2hvc3QtPmhv c3RfYnVzeSk7DQo+ICsNCj4gKwlzcGluX2xvY2tfaXJxKHNob3N0LT5ob3N0X2xvY2spOw0KPiAr CWlmICh1bmxpa2VseShzY3NpX2hvc3RfaW5fcmVjb3Zlcnkoc2hvc3QpICYmDQo+ICsJCSAgICAg KHNob3N0LT5ob3N0X2ZhaWxlZCB8fCBzaG9zdC0+aG9zdF9laF9zY2hlZHVsZWQpKSkNCj4gKwkJ c2NzaV9laF93YWtldXAoc2hvc3QpOw0KPiArCXNwaW5fdW5sb2NrX2lycShzaG9zdC0+aG9zdF9s b2NrKTsNCj4gKw0KPiAgCXJldHVybiAwOw0KPiAgfQ0KPiAgDQo+IEBAIC0xOTY0LDYgKzE5NzAs MTMgQEAgc3RhdGljIGJsa19zdGF0dXNfdCBzY3NpX3F1ZXVlX3JxKHN0cnVjdCBibGtfbXFfaHdf Y3R4ICpoY3R4LA0KPiAgDQo+ICBvdXRfZGVjX2hvc3RfYnVzeToNCj4gIAlhdG9taWNfZGVjKCZz aG9zdC0+aG9zdF9idXN5KTsNCj4gKw0KPiArCXNwaW5fbG9ja19pcnEoc2hvc3QtPmhvc3RfbG9j ayk7DQo+ICsJaWYgKHVubGlrZWx5KHNjc2lfaG9zdF9pbl9yZWNvdmVyeShzaG9zdCkgJiYNCj4g KwkJICAgICAoc2hvc3QtPmhvc3RfZmFpbGVkIHx8IHNob3N0LT5ob3N0X2VoX3NjaGVkdWxlZCkp KQ0KPiArCQlzY3NpX2VoX3dha2V1cChzaG9zdCk7DQo+ICsJc3Bpbl91bmxvY2tfaXJxKHNob3N0 LT5ob3N0X2xvY2spOw0KPiArDQo+ICBvdXRfZGVjX3RhcmdldF9idXN5Og0KPiAgCWlmIChzY3Np X3RhcmdldChzZGV2KS0+Y2FuX3F1ZXVlID4gMCkNCj4gIAkJYXRvbWljX2RlYygmc2NzaV90YXJn ZXQoc2RldiktPnRhcmdldF9idXN5KTsNCg0KQW4gaW1wb3J0YW50IGFjaGlldmVtZW50IG9mIHRo ZSBzY3NpLW1xIGNvZGUgd2FzIHJlbW92YWwgb2YgYWxsDQpzcGluX2xvY2tfaXJxKHNob3N0LT5o b3N0X2xvY2spIHN0YXRlbWVudHMgZnJvbSB0aGUgaG90IHBhdGguIFRoZSBhYm92ZQ0KY2hhbmdl cyB3aWxsIGhhdmUgYSBzaWduaWZpY2FudCBuZWdhdGl2ZSBwZXJmb3JtYW5jZSBpbXBhY3QsIGVz cGVjaWFsbHkgaWYNCm11bHRpcGxlIExVTnMgYXNzb2NpYXRlZCB3aXRoIHRoZSBzYW1lIFNDU0kg aG9zdCBhcmUgaW52b2x2ZWQuIENhbiB0aGUNCnJlcG9ydGVkIHJhY2UgYmUgZml4ZWQgd2l0aG91 dCBzbG93aW5nIGRvd24gdGhlIGhvdCBwYXRoIHNpZ25pZmljYW50bHk/IEkNCnRoaW5rIHRoYXQg Ym90aCBhZGRpbmcgc3BpbiBsb2NrIG9yIHNtcF9tYigpIGNhbGxzIGluIHRoZSBob3QgcGF0aCB3 aWxsDQpoYXZlIGEgc2lnbmlmaWNhbnQgbmVnYXRpdmUgcGVyZm9ybWFuY2UgaW1wYWN0Lg0KDQpU aGFua3MsDQoNCkJhcnQu