From: James Bottomley <jejb@linux.vnet.ibm.com>
To: Jason Yan <yanaijie@huawei.com>,
Bart Van Assche <Bart.VanAssche@wdc.com>,
"hch@lst.de" <hch@lst.de>
Cc: "zhaohongjiang@huawei.com" <zhaohongjiang@huawei.com>,
"jthumshirn@suse.de" <jthumshirn@suse.de>,
"martin.petersen@oracle.com" <martin.petersen@oracle.com>,
"hare@suse.de" <hare@suse.de>,
"linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
"gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
"miaoxie@huawei.com" <miaoxie@huawei.com>
Subject: Re: [PATCH] scsi: fix race condition when removing target
Date: Fri, 01 Dec 2017 07:35:56 -0800 [thread overview]
Message-ID: <1512142556.3053.4.camel@linux.vnet.ibm.com> (raw)
In-Reply-To: <5A211596.2010707@huawei.com>
On Fri, 2017-12-01 at 16:40 +0800, Jason Yan wrote:
> On 2017/12/1 7:56, James Bottomley wrote:
> > b/include/scsi/scsi_device.h
> > index 571ddb49b926..2e4d48d8cd68 100644
> > --- a/include/scsi/scsi_device.h
> > +++ b/include/scsi/scsi_device.h
> > @@ -380,6 +380,23 @@ extern struct scsi_device
> > *__scsi_iterate_devices(struct Scsi_Host *,
> > #define __shost_for_each_device(sdev, shost) \
> > list_for_each_entry((sdev), &((shost)->__devices),
> > siblings)
> >
>
> Seems that __shost_for_each_device() is still not safe. scsi device
> been deleted stays in the list and put_device() can be called
> anywhere out of the host lock.
Not if it's used with scsi_get_device(). As I said, I only did a
cursory inspectiont, so if I've missed a loop, please specify.
The point was more a demonstration of how we could fix the problem if
we don't change get_device().
James
next prev parent reply other threads:[~2017-12-01 15:36 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-29 3:05 [PATCH] scsi: fix race condition when removing target Jason Yan
2017-11-29 7:41 ` Hannes Reinecke
2017-11-29 16:18 ` Bart Van Assche
2017-11-29 16:20 ` hch
2017-11-29 17:39 ` Bart Van Assche
2017-11-30 1:18 ` Jason Yan
2017-11-30 16:08 ` Bart Van Assche
2017-11-30 16:40 ` gregkh
2017-11-30 23:56 ` James Bottomley
2017-12-01 1:12 ` Finn Thain
2017-12-01 8:40 ` Jason Yan
2017-12-01 14:41 ` Ewan D. Milne
2017-12-01 15:35 ` James Bottomley [this message]
2017-12-05 12:37 ` Jason Yan
2017-12-05 15:37 ` James Bottomley
2017-12-06 0:41 ` Jason Yan
2017-12-06 2:07 ` James Bottomley
2017-12-06 2:43 ` Jason Yan
2017-11-29 17:39 ` gregkh
2017-11-29 18:49 ` Ewan D. Milne
2017-11-29 19:11 ` Bart Van Assche
2017-11-29 19:20 ` Ewan D. Milne
2017-11-29 19:50 ` Bart Van Assche
2017-11-29 17:39 ` gregkh
2017-11-29 17:47 ` Bart Van Assche
2017-11-29 16:31 ` James Bottomley
2017-11-29 16:34 ` Christoph Hellwig
2017-11-29 16:47 ` James Bottomley
2017-11-29 19:05 ` Ewan D. Milne
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1512142556.3053.4.camel@linux.vnet.ibm.com \
--to=jejb@linux.vnet.ibm.com \
--cc=Bart.VanAssche@wdc.com \
--cc=gregkh@linuxfoundation.org \
--cc=hare@suse.de \
--cc=hch@lst.de \
--cc=jthumshirn@suse.de \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=miaoxie@huawei.com \
--cc=yanaijie@huawei.com \
--cc=zhaohongjiang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).