Re: [PATCH 03/43] qla2xxx: Use IOCB path to submit Control VP MBX command

Madhani, Himanshu
2017-12-20T20:39:40Z

> On Dec 20, 2017, at 10:29 AM, Bart Van Assche <bart.vanassche@wdc.com> wrote:
>
> On Tue, 2017-12-19 at 22:56 -0800, Himanshu Madhani wrote:
>> @@ -536,7 +541,7 @@ struct sp_name {
>> #define SRB_NVME_CMD 19
>> #define SRB_NVME_LS 20
>> #define SRB_PRLI_CMD 21
>> -
>> +#define SRB_CTRL_VP 22
>> enum {
>
> Please keep the blank line between the #define block and the enum definition.
>

Sure

>> +/*
>> + * qla24xx_control_vp
>> + * Enable a virtual port for given host
>> + *
>> + * Input:
>> + * ha = adapter block pointer.
>> + * vhba = virtual adapter (unused)
>> + * index = index number for enabled VP
>> + *
>> + * Returns:
>> + * qla2xxx local function return status code.
>> + *
>> + * Context:
>> + * Kernel context.
>> + */
>> +int
>> +qla24xx_control_vp(scsi_qla_host_t *vha, int cmd)
>
> Have you considered to use the kernel-doc style for this function header? See
> also https://www.kernel.org/doc/Documentation/kernel-doc-nano-HOWTO.txt.
>
> Thanks,
>
> Bart.

Will update to kernel-doc style for the header.

Thanks,
- Himanshu