From: Bart Van Assche <Bart.VanAssche@wdc.com>
To: "snitzer@redhat.com" <snitzer@redhat.com>
Cc: "linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
"hch@infradead.org" <hch@infradead.org>,
"martin.petersen@oracle.com" <martin.petersen@oracle.com>,
"ming.lei@redhat.com" <ming.lei@redhat.com>,
"axboe@kernel.dk" <axboe@kernel.dk>,
"linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
"jejb@linux.vnet.ibm.com" <jejb@linux.vnet.ibm.com>,
"loberman@redhat.com" <loberman@redhat.com>,
"dm-devel@redhat.com" <dm-devel@redhat.com>
Subject: Re: [PATCH V3] blk-mq: introduce BLK_STS_DEV_RESOURCE
Date: Sun, 28 Jan 2018 17:03:49 +0000 [thread overview]
Message-ID: <1517159028.3141.17.camel@wdc.com> (raw)
In-Reply-To: <20180128002356.GA25933@redhat.com>
On Sat, 2018-01-27 at 19:23 -0500, Mike Snitzer wrote:
> On Sat, Jan 27 2018 at 5:12pm -0500,
> Bart Van Assche <Bart.VanAssche@wdc.com> wrote:
> > - The patch at the start of this thread introduces a regression in the
> > SCSI core, namely a queue stall if a request completion occurs concurrently
> > with the newly added BLK_MQ_S_SCHED_RESTART test in the blk-mq core.
>
> And why is this supposed race unique to SCSI core?
That race is not unique to the SCSI core. It is possible that the patch at
the start of this thread introduces the same race in other block drivers
but I have not yet tried to verify that.
> Fact is Ming dutifully implemented what Jens suggested.
That's a misleading statement. Jens proposed to introduce a new status code
(which he called "NO_DEV_RESOURCE") but did not specify any of the other
aspects of Ming's patch. Jens definitely did not ask to introduce new race
conditions. See also https://www.spinics.net/lists/kernel/msg2703154.html
Bart.
next prev parent reply other threads:[~2018-01-28 17:03 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-23 16:16 [PATCH V3] blk-mq: introduce BLK_STS_DEV_RESOURCE Ming Lei
2018-01-23 16:20 ` Mike Snitzer
2018-01-23 16:24 ` Bart Van Assche
2018-01-23 16:37 ` Ming Lei
2018-01-23 16:57 ` Bart Van Assche
2018-01-24 3:31 ` Ming Lei
2018-01-27 19:09 ` Mike Snitzer
2018-01-27 22:12 ` Bart Van Assche
2018-01-27 23:41 ` Ming Lei
2018-01-29 16:48 ` Bart Van Assche
2018-01-30 1:07 ` Ming Lei
2018-01-30 1:11 ` Bart Van Assche
2018-01-30 3:31 ` Ming Lei
2018-01-30 3:37 ` Bart Van Assche
2018-01-30 3:42 ` Ming Lei
2018-01-28 0:23 ` Mike Snitzer
2018-01-28 0:54 ` Bart Van Assche
2018-01-28 2:03 ` Mike Snitzer
2018-01-28 3:00 ` Bart Van Assche
2018-01-28 4:58 ` Mike Snitzer
2018-01-28 16:57 ` Bart Van Assche
2018-01-28 17:26 ` Laurence Oberman
2018-01-28 11:39 ` Ming Lei
2018-01-28 17:03 ` Bart Van Assche [this message]
2018-01-29 2:14 ` Ming Lei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1517159028.3141.17.camel@wdc.com \
--to=bart.vanassche@wdc.com \
--cc=axboe@kernel.dk \
--cc=dm-devel@redhat.com \
--cc=hch@infradead.org \
--cc=jejb@linux.vnet.ibm.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=loberman@redhat.com \
--cc=martin.petersen@oracle.com \
--cc=ming.lei@redhat.com \
--cc=snitzer@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox