public inbox for linux-scsi@vger.kernel.org
 help / color / mirror / Atom feed
From: Laurence Oberman <loberman@redhat.com>
To: dgilbert <dgilbert@interlog.com>,
	linux-scsi@vger.kernel.org,
	Bart Van Assche <Bart.VanAssche@wdc.com>
Cc: John Pittman <jpittman@redhat.com>, Jon Magrini <jmagrini@redhat.com>
Subject: Re: All scsi_debug devices in the scsi_debug driver share the same RAM space
Date: Mon, 05 Feb 2018 09:32:31 -0500	[thread overview]
Message-ID: <1517841151.11655.1.camel@redhat.com> (raw)
In-Reply-To: <1517686992.18584.8.camel@redhat.com>

On Sat, 2018-02-03 at 14:43 -0500, Laurence Oberman wrote:
> Hello Doug
> 
> I had emailed you earlier about this issue forgetting to copy others.
> 
> All test devices in the scsi_debug driver share the same ram space so
> we cannot really have individual devices for testing stuff like md-
> raid.
> 
> I bumped into this a few times already and I think it would be useful
> to make each device an individual RAM entry so we can create multiple
> unique devices.
> 
> Of course this means also now having to maybe start using attributes
> for each device do we can selectively choose which devices get the
> fault injections.
> 
> I know its adding complexity here but wanted to get input about the
> possibility of changing this.
> 
> For a particular fault injection case this morning I had to use 5
> regular drives and 1 scsi-debug drive to inject faults to reproduce
> an
> md-raid issue.
> 
> I also wanted a different start sector and range and sent an earlier
> patch for that.
> 
> So is this something worth considering ?
> If so, i will start working on it.
> 
> Regards
> Laurence
> 
> 
> 
> 

I chatted with Doug about this.

Seems that many of the use cases for scsi_debug involved creating high
count devices for testing etc. so having each with its own ram space
could land up chewing a bunch of memory.

I am going to drop this idea for now, but the patch I sent for the
choice of sector for MEDIUM errors and count is very useful so I hope
that one gets accepted.
That patch changes nothing if the two new parameters are not set so
should be low risk for acceptance.

Thanks
Laurence

  reply	other threads:[~2018-02-05 14:32 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-02-03 19:43 All scsi_debug devices in the scsi_debug driver share the same RAM space Laurence Oberman
2018-02-05 14:32 ` Laurence Oberman [this message]
     [not found]   ` <CAM4Jq_43+JrSTvXsq7kgRLikqHb2iwFMYKTBuQjQ5h2Dn1ka+A@mail.gmail.com>
2018-02-12 15:04     ` Fwd: " Lukas Herbolt
2018-02-14  2:14       ` Martin K. Petersen
2018-02-14 18:45         ` Laurence Oberman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1517841151.11655.1.camel@redhat.com \
    --to=loberman@redhat.com \
    --cc=Bart.VanAssche@wdc.com \
    --cc=dgilbert@interlog.com \
    --cc=jmagrini@redhat.com \
    --cc=jpittman@redhat.com \
    --cc=linux-scsi@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox