From: "Ewan D. Milne" <emilne@redhat.com>
To: James Smart <jsmart2021@gmail.com>
Cc: hare@suse.com, martin.petersen@oracle.com,
dick.kennedy@broadcom.com, linux-next@vger.kernel.org,
sfr@canb.auug.org.au, linux-nvme@lists.infradead.org,
sagi@grimberg.me, linux-scsi@vger.kernel.org
Subject: Re: [PATCH] lpfc: add missing Kconfig NVME dependencies
Date: Thu, 15 Feb 2018 14:00:30 -0500 [thread overview]
Message-ID: <1518721230.2427.82.camel@localhost.localdomain> (raw)
In-Reply-To: <58adba5f.BoP49Cv2S5zD9ZuD%jsmart2021@gmail.com>
On Wed, 2017-02-22 at 08:20 -0800, James Smart wrote:
> add missing Kconfig NVME dependencies
>
> Can't believe I missed posting this
>
> -- james
>
> Signed-off-by: James Smart <james.smart@broadcom.com>
> ---
> drivers/scsi/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/scsi/Kconfig b/drivers/scsi/Kconfig
> index d4023bf..2558434 100644
> --- a/drivers/scsi/Kconfig
> +++ b/drivers/scsi/Kconfig
> @@ -1240,6 +1240,7 @@ config SCSI_LPFC
> tristate "Emulex LightPulse Fibre Channel Support"
> depends on PCI && SCSI
> depends on SCSI_FC_ATTRS
> + depends on NVME_FC && NVME_TARGET_FC
> select CRC_T10DIF
> help
> This lpfc driver supports the Emulex LightPulse
I thought this was why you had
#if (IS_ENABLED(CONFIG_NVME_FC))
#if (IS_ENABLED(CONFIG_NVME_TARGET_FC))
at various places in the lpfc driver. Do you actually depend
on having NVME_FC and NVME_TARGET_FC, or do you selectively
include code if they are config'ed in?
Or do you want to force-enable it at this point?
-Ewan
next prev parent reply other threads:[~2018-02-15 19:00 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-22 16:20 [PATCH] lpfc: add missing Kconfig NVME dependencies James Smart
2017-02-22 19:35 ` Sagi Grimberg
2017-02-23 10:09 ` Christoph Hellwig
2017-02-23 15:51 ` James Smart
2018-02-15 19:00 ` Ewan D. Milne [this message]
2018-02-15 19:02 ` Ewan D. Milne
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1518721230.2427.82.camel@localhost.localdomain \
--to=emilne@redhat.com \
--cc=dick.kennedy@broadcom.com \
--cc=hare@suse.com \
--cc=jsmart2021@gmail.com \
--cc=linux-next@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=sagi@grimberg.me \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox