From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bart Van Assche Subject: Re: [PATCH] libosd: Remove ignored __weak attribute Date: Fri, 26 Oct 2018 11:01:48 -0700 Message-ID: <1540576908.66186.103.camel@acm.org> References: <20180930205448.26205-1-natechancellor@gmail.com> <10b12992-3570-4646-374b-82cbd7276839@acm.org> <1538503063.193396.6.camel@acm.org> <1538521591.193396.8.camel@acm.org> <20181025213144.GB24709@flashbox> <20181025225548.GA10326@flashbox> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-7" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: Nick Desaulniers , Nathan Chancellor Cc: ooo@electrozaur.com, "James E.J. Bottomley" , "Martin K. Petersen" , linux-scsi@vger.kernel.org, LKML , hch@infradead.org List-Id: linux-scsi@vger.kernel.org On Fri, 2018-10-26 at 10:54 -0700, Nick Desaulniers wrote: +AD4 If creating one instance of this variable is a functional change, I +AD4 can't help but suspect the original code was wrong. But maybe Bart, +AD4 Boaz, or Christoph can clarify or have more thoughts on this? Looks +AD4 like Boaz added this header in commit de258bf5e638 (+ACIAWw-SCSI+AF0 libosd: +AD4 OSDv1 Headers+ACI). Hi Nick and Nathan, Had you noticed the following e-mail from early October: https://marc.info/?l+AD0-linux-kernel+ACY-m+AD0-153849955503249? Thanks, Bart.