From: "Enrico Weigelt, metux IT consult" <info@metux.net>
To: linux-kernel@vger.kernel.org
Cc: rjw@rjwysocki.net, viresh.kumar@linaro.org, jdelvare@suse.com,
linux@roeck-us.net, khalid@gonehiking.org, jejb@linux.ibm.com,
martin.petersen@oracle.com, aacraid@microsemi.com,
linux-pm@vger.kernel.org, linux-hwmon@vger.kernel.org,
linux-scsi@vger.kernel.org
Subject: [PATCH 3/3] drivers: hwmon: i5k_amb: remove unnecessary #ifdef MODULE
Date: Fri, 31 May 2019 17:09:04 +0200 [thread overview]
Message-ID: <1559315344-10384-4-git-send-email-info@metux.net> (raw)
In-Reply-To: <1559315344-10384-1-git-send-email-info@metux.net>
The MODULE_DEVICE_TABLE() macro already checks for MODULE defined,
so the extra check here is not necessary.
Signed-off-by: Enrico Weigelt <info@metux.net>
---
drivers/hwmon/i5k_amb.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/hwmon/i5k_amb.c b/drivers/hwmon/i5k_amb.c
index 2cf73d8..622405b 100644
--- a/drivers/hwmon/i5k_amb.c
+++ b/drivers/hwmon/i5k_amb.c
@@ -495,14 +495,12 @@ static int i5k_channel_probe(u16 *amb_present, unsigned long dev_id)
{ 0, 0 }
};
-#ifdef MODULE
static const struct pci_device_id i5k_amb_ids[] = {
{ PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_5000_ERR) },
{ PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_5400_ERR) },
{ 0, }
};
MODULE_DEVICE_TABLE(pci, i5k_amb_ids);
-#endif
static int i5k_amb_probe(struct platform_device *pdev)
{
--
1.9.1
next prev parent reply other threads:[~2019-05-31 15:09 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-31 15:09 clean some unneeded #ifdef MODULE Enrico Weigelt, metux IT consult
2019-05-31 15:09 ` [PATCH 1/3] drivers: cpufreq: cpufreq-nforce2: remove unnecessary " Enrico Weigelt, metux IT consult
2019-05-31 15:09 ` [PATCH 2/3] drivers: scsci: " Enrico Weigelt, metux IT consult
2019-05-31 15:09 ` Enrico Weigelt, metux IT consult [this message]
2019-05-31 15:15 ` clean some unneeded " James Bottomley
-- strict thread matches above, loose matches on Subject: below --
2019-06-01 14:01 remove " Enrico Weigelt, metux IT consult
2019-06-01 14:01 ` [PATCH 3/3] drivers: hwmon: i5k_amb: remove unnecessary " Enrico Weigelt, metux IT consult
2019-06-01 22:49 ` Guenter Roeck
2019-06-05 23:59 ` Enrico Weigelt, metux IT consult
2019-06-06 1:35 ` Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1559315344-10384-4-git-send-email-info@metux.net \
--to=info@metux.net \
--cc=aacraid@microsemi.com \
--cc=jdelvare@suse.com \
--cc=jejb@linux.ibm.com \
--cc=khalid@gonehiking.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=martin.petersen@oracle.com \
--cc=rjw@rjwysocki.net \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).