From: James Bottomley <jejb@linux.ibm.com>
To: "Enrico Weigelt, metux IT consult" <info@metux.net>,
linux-kernel@vger.kernel.org
Cc: rjw@rjwysocki.net, viresh.kumar@linaro.org, jdelvare@suse.com,
linux@roeck-us.net, khalid@gonehiking.org,
martin.petersen@oracle.com, aacraid@microsemi.com,
linux-pm@vger.kernel.org, linux-hwmon@vger.kernel.org,
linux-scsi@vger.kernel.org
Subject: Re: clean some unneeded #ifdef MODULE
Date: Fri, 31 May 2019 18:15:24 +0300 [thread overview]
Message-ID: <1559315724.2878.7.camel@linux.ibm.com> (raw)
In-Reply-To: <1559315344-10384-1-git-send-email-info@metux.net>
On Fri, 2019-05-31 at 17:09 +0200, Enrico Weigelt, metux IT consult
wrote:
> Hi folks,
>
> here're some patches that clean up uncessary cases of #ifdef MODULE.
> These ifdef's just exlude MODULE_DEVICE_TABLE's when the kernel is
> built w/o module support. As MODULE_DEVICE_TABLE() macro already
> checks for that, these extra #ifdef's shouldn't be necessary.
Isn't the problem the #ifdefs are trying to solve a complaint about an
unused variable in the non-module case? if so, is that fixed some other
way?
James
prev parent reply other threads:[~2019-05-31 15:15 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-31 15:09 clean some unneeded #ifdef MODULE Enrico Weigelt, metux IT consult
2019-05-31 15:09 ` [PATCH 1/3] drivers: cpufreq: cpufreq-nforce2: remove unnecessary " Enrico Weigelt, metux IT consult
2019-05-31 15:09 ` [PATCH 2/3] drivers: scsci: " Enrico Weigelt, metux IT consult
2019-05-31 15:09 ` [PATCH 3/3] drivers: hwmon: i5k_amb: " Enrico Weigelt, metux IT consult
2019-05-31 15:15 ` James Bottomley [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1559315724.2878.7.camel@linux.ibm.com \
--to=jejb@linux.ibm.com \
--cc=aacraid@microsemi.com \
--cc=info@metux.net \
--cc=jdelvare@suse.com \
--cc=khalid@gonehiking.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=martin.petersen@oracle.com \
--cc=rjw@rjwysocki.net \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).