From: James Bottomley <jejb@linux.ibm.com>
To: Keyur Patel <iamkeyur96@gmail.com>
Cc: "Martin K. Petersen" <martin.petersen@oracle.com>,
linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] scsi: aha1740: Use !x in place of NULL comparisons
Date: Thu, 11 Jul 2019 16:52:04 -0700 [thread overview]
Message-ID: <1562889124.2915.5.camel@linux.ibm.com> (raw)
In-Reply-To: <20190711234833.27475-1-iamkeyur96@gmail.com>
On Thu, 2019-07-11 at 19:48 -0400, Keyur Patel wrote:
> Change (x == NULL) to !x and (x != NULL) to x, to fix
> following checkpatch.pl warnings:
> CHECK: Comparison to NULL could be written "!x".
This is one of our significantly older drivers. We try not to touch it
unless we really have to, so I'd rather not have patches like this
applied to it.
I also don't really think the replacement adds anything to readability,
so it should probably be removed from the checkpatch warnings.
Thanks,
James
next prev parent reply other threads:[~2019-07-11 23:52 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-11 23:48 [PATCH] scsi: aha1740: Use !x in place of NULL comparisons Keyur Patel
2019-07-11 23:52 ` James Bottomley [this message]
2019-07-12 0:38 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1562889124.2915.5.camel@linux.ibm.com \
--to=jejb@linux.ibm.com \
--cc=iamkeyur96@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).