From: Souptick Joarder <jrdr.linux@gmail.com>
To: hare@suse.com, jejb@linux.ibm.com, martin.petersen@oracle.com
Cc: linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org,
Souptick Joarder <jrdr.linux@gmail.com>
Subject: [PATCH] scsi: aic7xxx: Remove dead code
Date: Sat, 24 Aug 2019 20:38:22 +0530 [thread overview]
Message-ID: <1566659302-3514-1-git-send-email-jrdr.linux@gmail.com> (raw)
These are dead code since 2.6.13. If there is no plan
to use it further, these can be removed forever.
Signed-off-by: Souptick Joarder <jrdr.linux@gmail.com>
---
drivers/scsi/aic7xxx/aic7xxx_osm.c | 68 --------------------------------------
1 file changed, 68 deletions(-)
diff --git a/drivers/scsi/aic7xxx/aic7xxx_osm.c b/drivers/scsi/aic7xxx/aic7xxx_osm.c
index d5c4a0d..98d2e14 100644
--- a/drivers/scsi/aic7xxx/aic7xxx_osm.c
+++ b/drivers/scsi/aic7xxx/aic7xxx_osm.c
@@ -2445,68 +2445,6 @@ static void ahc_linux_set_dt(struct scsi_target *starget, int dt)
ahc_unlock(ahc, &flags);
}
-#if 0
-/* FIXME: This code claims to support IU and QAS. However, the actual
- * sequencer code and aic7xxx_core have no support for these parameters and
- * will get into a bad state if they're negotiated. Do not enable this
- * unless you know what you're doing */
-static void ahc_linux_set_qas(struct scsi_target *starget, int qas)
-{
- struct Scsi_Host *shost = dev_to_shost(starget->dev.parent);
- struct ahc_softc *ahc = *((struct ahc_softc **)shost->hostdata);
- struct ahc_tmode_tstate *tstate;
- struct ahc_initiator_tinfo *tinfo
- = ahc_fetch_transinfo(ahc,
- starget->channel + 'A',
- shost->this_id, starget->id, &tstate);
- struct ahc_devinfo devinfo;
- unsigned int ppr_options = tinfo->goal.ppr_options
- & ~MSG_EXT_PPR_QAS_REQ;
- unsigned int period = tinfo->goal.period;
- unsigned long flags;
- struct ahc_syncrate *syncrate;
-
- if (qas)
- ppr_options |= MSG_EXT_PPR_QAS_REQ;
-
- ahc_compile_devinfo(&devinfo, shost->this_id, starget->id, 0,
- starget->channel + 'A', ROLE_INITIATOR);
- syncrate = ahc_find_syncrate(ahc, &period, &ppr_options, AHC_SYNCRATE_DT);
- ahc_lock(ahc, &flags);
- ahc_set_syncrate(ahc, &devinfo, syncrate, period, tinfo->goal.offset,
- ppr_options, AHC_TRANS_GOAL, FALSE);
- ahc_unlock(ahc, &flags);
-}
-
-static void ahc_linux_set_iu(struct scsi_target *starget, int iu)
-{
- struct Scsi_Host *shost = dev_to_shost(starget->dev.parent);
- struct ahc_softc *ahc = *((struct ahc_softc **)shost->hostdata);
- struct ahc_tmode_tstate *tstate;
- struct ahc_initiator_tinfo *tinfo
- = ahc_fetch_transinfo(ahc,
- starget->channel + 'A',
- shost->this_id, starget->id, &tstate);
- struct ahc_devinfo devinfo;
- unsigned int ppr_options = tinfo->goal.ppr_options
- & ~MSG_EXT_PPR_IU_REQ;
- unsigned int period = tinfo->goal.period;
- unsigned long flags;
- struct ahc_syncrate *syncrate;
-
- if (iu)
- ppr_options |= MSG_EXT_PPR_IU_REQ;
-
- ahc_compile_devinfo(&devinfo, shost->this_id, starget->id, 0,
- starget->channel + 'A', ROLE_INITIATOR);
- syncrate = ahc_find_syncrate(ahc, &period, &ppr_options, AHC_SYNCRATE_DT);
- ahc_lock(ahc, &flags);
- ahc_set_syncrate(ahc, &devinfo, syncrate, period, tinfo->goal.offset,
- ppr_options, AHC_TRANS_GOAL, FALSE);
- ahc_unlock(ahc, &flags);
-}
-#endif
-
static void ahc_linux_get_signalling(struct Scsi_Host *shost)
{
struct ahc_softc *ahc = *(struct ahc_softc **)shost->hostdata;
@@ -2545,12 +2483,6 @@ static void ahc_linux_get_signalling(struct Scsi_Host *shost)
.show_width = 1,
.set_dt = ahc_linux_set_dt,
.show_dt = 1,
-#if 0
- .set_iu = ahc_linux_set_iu,
- .show_iu = 1,
- .set_qas = ahc_linux_set_qas,
- .show_qas = 1,
-#endif
.get_signalling = ahc_linux_get_signalling,
};
--
1.9.1
next reply other threads:[~2019-08-24 15:02 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-24 15:08 Souptick Joarder [this message]
2019-08-26 8:31 ` [PATCH] scsi: aic7xxx: Remove dead code James Bottomley
2019-08-26 12:10 ` Souptick Joarder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1566659302-3514-1-git-send-email-jrdr.linux@gmail.com \
--to=jrdr.linux@gmail.com \
--cc=hare@suse.com \
--cc=jejb@linux.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox