From: James Bottomley <jejb@linux.ibm.com>
To: Souptick Joarder <jrdr.linux@gmail.com>,
hare@suse.com, martin.petersen@oracle.com
Cc: linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] scsi: aic7xxx: Remove dead code
Date: Mon, 26 Aug 2019 09:31:47 +0100 [thread overview]
Message-ID: <1566808307.3089.2.camel@linux.ibm.com> (raw)
In-Reply-To: <1566659302-3514-1-git-send-email-jrdr.linux@gmail.com>
On Sat, 2019-08-24 at 20:38 +0530, Souptick Joarder wrote:
> These are dead code since 2.6.13. If there is no plan
> to use it further, these can be removed forever.
Unless you can articulate a clear useful reason for the removal I'd
rather keep this and the other code. Most of the documentation for
this chip is lost in the mists of time, so code fragments like this are
the only way we know how it was supposed to work.
A clear reason might be that it's impossible for aic7xxx ever to make
use of IU and QAS because they're LVD parameters and it's a SE/HVD
card, so the documentation in the code is actively wrong, but you'd
need to research that.
James
next prev parent reply other threads:[~2019-08-26 8:33 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-24 15:08 [PATCH] scsi: aic7xxx: Remove dead code Souptick Joarder
2019-08-26 8:31 ` James Bottomley [this message]
2019-08-26 12:10 ` Souptick Joarder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1566808307.3089.2.camel@linux.ibm.com \
--to=jejb@linux.ibm.com \
--cc=hare@suse.com \
--cc=jrdr.linux@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox