From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, UNPARSEABLE_RELAY,URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D3CF5C49ED9 for ; Thu, 12 Sep 2019 05:39:35 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id B11DB208E4 for ; Thu, 12 Sep 2019 05:39:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726215AbfILFjf (ORCPT ); Thu, 12 Sep 2019 01:39:35 -0400 Received: from mailgw02.mediatek.com ([210.61.82.184]:18166 "EHLO mailgw02.mediatek.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1726157AbfILFjf (ORCPT ); Thu, 12 Sep 2019 01:39:35 -0400 X-UUID: 91465c4520cd4888bff19885c7e4dc82-20190912 X-UUID: 91465c4520cd4888bff19885c7e4dc82-20190912 Received: from mtkexhb02.mediatek.inc [(172.21.101.103)] by mailgw02.mediatek.com (envelope-from ) (Cellopoint E-mail Firewall v4.1.10 Build 0809 with TLS) with ESMTP id 1676963458; Thu, 12 Sep 2019 13:39:27 +0800 Received: from mtkcas08.mediatek.inc (172.21.101.126) by mtkmbs01n1.mediatek.inc (172.21.101.68) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Thu, 12 Sep 2019 13:39:25 +0800 Received: from [172.21.77.33] (172.21.77.33) by mtkcas08.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1395.4 via Frontend Transport; Thu, 12 Sep 2019 13:39:25 +0800 Message-ID: <1568266766.16730.15.camel@mtkswgap22> Subject: RE: [PATCH v1 3/3] scsi: ufs-mediatek: enable auto suspend capability From: Stanley Chu To: Avri Altman CC: "linux-scsi@vger.kernel.org" , "martin.petersen@oracle.com" , "alim.akhtar@samsung.com" , "pedrom.sousa@synopsys.com" , "sthumma@codeaurora.org" , "jejb@linux.ibm.com" , "bvanassche@acm.org" , "linux-mediatek@lists.infradead.org" , "linux-arm-kernel@lists.infradead.org" , "matthias.bgg@gmail.com" , "evgreen@chromium.org" , "beanhuo@micron.com" , "marc.w.gonzalez@free.fr" , "subhashj@codeaurora.org" , "vivek.gautam@codeaurora.org" , "kuohong.wang@mediatek.com" , "peter.wang@mediatek.com" , "chun-hung.wu@mediatek.com" , "andy.teng@mediatek.com" Date: Thu, 12 Sep 2019 13:39:26 +0800 In-Reply-To: References: <1568194890-24439-1-git-send-email-stanley.chu@mediatek.com> <1568194890-24439-4-git-send-email-stanley.chu@mediatek.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.2.3-0ubuntu6 Content-Transfer-Encoding: 7bit MIME-Version: 1.0 X-MTK: N Sender: linux-scsi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org Hi Avri, On Wed, 2019-09-11 at 10:58 +0000, Avri Altman wrote: > > > > Enable auto suspend capability in MediaTek UFS driver. > > > > Signed-off-by: Stanley Chu > Reviewed-by: Avri Altman > > > --- > > drivers/scsi/ufs/ufs-mediatek.c | 7 +++++++ > > 1 file changed, 7 insertions(+) > > > > diff --git a/drivers/scsi/ufs/ufs-mediatek.c b/drivers/scsi/ufs/ufs-mediatek.c > > index 0f6ff33ce52e..b7b177c6194c 100644 > > --- a/drivers/scsi/ufs/ufs-mediatek.c > > +++ b/drivers/scsi/ufs/ufs-mediatek.c > > @@ -117,6 +117,11 @@ static int ufs_mtk_setup_clocks(struct ufs_hba > > *hba, bool on, > > return ret; > > } > > > > +static void ufs_mtk_set_caps(struct ufs_hba *hba) { > > + hba->caps |= UFSHCD_CAP_RPM_AUTOSUSPEND; } > Even a one-liner deserve new line for its closing brackets The wired format is just happening the same as [PATCH v1 2/3] scsi: ufs: override auto suspend tunables for ufs It looks fine in patchwork website: https://patchwork.kernel.org/patch/11140757/ I'll try to fix it in v2. Thanks, Stanley