From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,USER_AGENT_SANE_2 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E2260ECDE20 for ; Thu, 12 Sep 2019 08:33:22 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id B5D48208E4 for ; Thu, 12 Sep 2019 08:33:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730218AbfILIdW (ORCPT ); Thu, 12 Sep 2019 04:33:22 -0400 Received: from mailgw01.mediatek.com ([210.61.82.183]:54959 "EHLO mailgw01.mediatek.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1726952AbfILIdV (ORCPT ); Thu, 12 Sep 2019 04:33:21 -0400 X-UUID: 0fea203b718047a3a7b385b8d3e944dd-20190912 X-UUID: 0fea203b718047a3a7b385b8d3e944dd-20190912 Received: from mtkcas09.mediatek.inc [(172.21.101.178)] by mailgw01.mediatek.com (envelope-from ) (Cellopoint E-mail Firewall v4.1.10 Build 0809 with TLS) with ESMTP id 1078287574; Thu, 12 Sep 2019 16:33:13 +0800 Received: from mtkcas08.mediatek.inc (172.21.101.126) by mtkmbs07n1.mediatek.inc (172.21.101.16) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Thu, 12 Sep 2019 16:33:11 +0800 Received: from [172.21.77.33] (172.21.77.33) by mtkcas08.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1395.4 via Frontend Transport; Thu, 12 Sep 2019 16:33:11 +0800 Message-ID: <1568277192.16730.16.camel@mtkswgap22> Subject: Re: [PATCH v1 1/2] block: bypass blk_set_runtime_active for uninitialized q->dev From: Stanley Chu To: Jens Axboe CC: "linux-scsi@vger.kernel.org" , "linux-block@vger.kernel.org" , "martin.petersen@oracle.com" , "jejb@linux.ibm.com" , "matthias.bgg@gmail.com" , "linux-mediatek@lists.infradead.org" , "linux-arm-kernel@lists.infradead.org" , Kuohong Wang =?UTF-8?Q?=28=E7=8E=8B=E5=9C=8B=E9=B4=BB=29?= , Peter Wang =?UTF-8?Q?=28=E7=8E=8B=E4=BF=A1=E5=8F=8B=29?= , Chun-Hung Wu =?UTF-8?Q?=28=E5=B7=AB=E9=A7=BF=E5=AE=8F=29?= , Andy Teng =?UTF-8?Q?=28=E9=84=A7=E5=A6=82=E5=AE=8F=29?= Date: Thu, 12 Sep 2019 16:33:12 +0800 In-Reply-To: <66fddf12-0dc4-1c73-affd-f8404e87342f@kernel.dk> References: <1568183562-18241-1-git-send-email-stanley.chu@mediatek.com> <1568183562-18241-2-git-send-email-stanley.chu@mediatek.com> <66fddf12-0dc4-1c73-affd-f8404e87342f@kernel.dk> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.2.3-0ubuntu6 Content-Transfer-Encoding: 7bit MIME-Version: 1.0 X-MTK: N Sender: linux-scsi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org Hi Jens, > > void blk_set_runtime_active(struct request_queue *q) > > { > > + if (!q->dev) > > + return; > > + > > spin_lock_irq(&q->queue_lock); > > q->rpm_status = RPM_ACTIVE; > > pm_runtime_mark_last_busy(q->dev); > > I'd prefer just doing: > > if (q->dev) { > ... > } > > instead. Other than that little complaint, looks good to me. > OK! I will change it in v2. Thanks, Stanley