From: Mike Christie <michael.christie@oracle.com>
To: mlombard@redhat.com, martin.petersen@oracle.com,
linux-scsi@vger.kernel.org, target-devel@vger.kernel.org
Subject: Re: [PATCH 5/7] scsi: target: iscsit/isert: stop/wait on cmds during conn close
Date: Sat, 10 Dec 2022 19:20:40 -0600 [thread overview]
Message-ID: <157ae074-b455-c604-2a5b-1b70ca9839ba@oracle.com> (raw)
In-Reply-To: <20221208031002.106700-6-michael.christie@oracle.com>
On 12/7/22 9:10 PM, Mike Christie wrote:
> static void iscsit_stop_timers_for_cmds(
> @@ -4304,6 +4313,8 @@ int iscsit_close_connection(
> iscsit_stop_nopin_response_timer(conn);
> iscsit_stop_nopin_timer(conn);
>
> + target_stop_cmd_counter(conn->cmd_cnt);
> +
> if (conn->conn_transport->iscsit_wait_conn)
> conn->conn_transport->iscsit_wait_conn(conn);
>
Maurizo, don't test these patches. There is a bug where we have
a missing target_stop_cmd_counter. If the login fails then we
don't go through this path and will not do a stop.
I'll send a updated patchset later.
next prev parent reply other threads:[~2022-12-11 1:20 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-08 3:09 [PATCH 0/7] scsi target task management fixes Mike Christie
2022-12-08 3:09 ` [PATCH 1/7] scsi: target: Move sess cmd counter to new struct Mike Christie
2022-12-08 3:09 ` [PATCH 2/7] scsi: target: Move cmd counter allocation Mike Christie
2022-12-08 3:09 ` [PATCH 3/7] scsi: target: Pass in cmd counter to use during cmd setup Mike Christie
2022-12-08 3:09 ` [PATCH 4/7] scsi: target: iscsit: Alloc per conn cmd counter Mike Christie
2022-12-08 3:10 ` [PATCH 5/7] scsi: target: iscsit/isert: stop/wait on cmds during conn close Mike Christie
2022-12-09 12:32 ` Dmitry Bogdanov
2022-12-10 18:48 ` Mike Christie
2022-12-11 1:38 ` Mike Christie
2023-01-12 3:11 ` Mike Christie
2022-12-11 1:20 ` Mike Christie [this message]
2022-12-08 3:10 ` [PATCH 6/7] scsi: target: drop tas arg from __transport_wait_for_tasks Mike Christie
2022-12-08 9:24 ` Dmitry Bogdanov
2022-12-08 3:10 ` [PATCH 7/7] scsi: target: Fix multiple LUN_RESET handling Mike Christie
2022-12-08 9:21 ` Dmitry Bogdanov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=157ae074-b455-c604-2a5b-1b70ca9839ba@oracle.com \
--to=michael.christie@oracle.com \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=mlombard@redhat.com \
--cc=target-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox