Re: [PATCH v2 1/3] scsi: ufs: remove max_t in ufs_get_device_desc

Bean Huo
2020-05-28T15:04:37Z

On Thu, 2020-05-28 at 07:56 -0700, Bart Van Assche wrote:
> > - buff_len = max_t(size_t, hba->desc_size.dev_desc,
> > - QUERY_DESC_MAX_SIZE + 1);
> > + buff_len = QUERY_DESC_MAX_SIZE + 1;
> > desc_buf = kmalloc(buff_len, GFP_KERNEL);
> > if (!desc_buf) {
> > err = -ENOMEM;
>
> Since the buff_len variable is not changed after its initial
> assignment,
> please remove it entirely.
>
> Thanks,
>
> Bart.

hi, Bart

Thanks.

do you mean like this: buff_len = hba->desc_size[id]?

Bean