public inbox for linux-scsi@vger.kernel.org
 help / color / mirror / Atom feed
From: James Bottomley <jejb@linux.ibm.com>
To: Anjali Kulkarni <Anjali.K.Kulkarni@oracle.com>,
	martin.petersen@oracle.com
Cc: linux-scsi@vger.kernel.org
Subject: Re: [PATCH] scsi: Avoid unnecessary iterations on __scsi_scan_target
Date: Fri, 26 Jun 2020 17:21:44 -0700	[thread overview]
Message-ID: <1593217304.10175.4.camel@linux.ibm.com> (raw)
In-Reply-To: <7917b23d-0222-d0c7-42a4-b3f18ac24ec2@oracle.com>

On Fri, 2020-06-26 at 17:17 -0700, Anjali Kulkarni wrote:
> Thanks James.
> 
> This is on a VM on OCI cloud, using virtio scsi.
> 
> Here is output of lspci on the VM:
> 
> 00:00.0 Host bridge: Intel Corporation 440FX - 82441FX PMC [Natoma]
> (rev 02)
> 00:01.0 ISA bridge: Intel Corporation 82371SB PIIX3 ISA
> [Natoma/Triton II]
> 00:01.1 IDE interface: Intel Corporation 82371SB PIIX3 IDE 
> [Natoma/Triton II]
> 00:01.2 USB controller: Intel Corporation 82371SB PIIX3 USB 
> [Natoma/Triton II] (rev 01)
> 00:01.3 Bridge: Intel Corporation 82371AB/EB/MB PIIX4 ACPI (rev 03)
> 00:02.0 VGA compatible controller: Device 1234:1111 (rev 02)
> 00:03.0 Ethernet controller: Red Hat, Inc. Virtio network device
> 00:04.0 SCSI storage controller: Red Hat, Inc. Virtio SCSI

I think the right thing to do would be to fix virtio-SCSI.  It already
has the guest to host communication to know how many targets are
configured.  There's shouldn't be any need to do scanning.

James


      reply	other threads:[~2020-06-27  0:22 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-26 23:53 [PATCH] scsi: Avoid unnecessary iterations on __scsi_scan_target Anjali Kulkarni
2020-06-27  0:03 ` James Bottomley
2020-06-27  0:17   ` Anjali Kulkarni
2020-06-27  0:21     ` James Bottomley [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1593217304.10175.4.camel@linux.ibm.com \
    --to=jejb@linux.ibm.com \
    --cc=Anjali.K.Kulkarni@oracle.com \
    --cc=linux-scsi@vger.kernel.org \
    --cc=martin.petersen@oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox