Re: [PATCH] scsi: sd: add runtime pm to open / release

Alan Stern
2020-07-29T16:17:25Z

On Wed, Jul 29, 2020 at 08:49:34AM -0700, James Bottomley wrote:
> On Wed, 2020-07-29 at 11:40 -0400, Alan Stern wrote:
> > On Wed, Jul 29, 2020 at 07:53:52AM -0700, James Bottomley wrote:
> > > On Wed, 2020-07-29 at 07:46 -0700, James Bottomley wrote:
> [...]
> > > > That sense code means "NOT READY TO READY CHANGE, MEDIUM MAY HAVE
> > > > CHANGED" so it sounds like it something we should be
> > > > ignoring. Usually this signals a problem, like you changed the
> > > > medium manually (ejected the CD). But in this case you can tell
> > > > us to expect this by setting
> > > >
> > > > sdev->expecting_cc_ua
> > > >
> > > > And we'll retry. I think you need to set this on all resumed
> > > > devices.
> > >
> > > Actually, it's not quite that easy, we filter out this ASC/ASCQ
> > > combination from the check because we should never ignore medium
> > > might have changed events on running devices. We could ignore it
> > > if we had a flag to say the power has been yanked (perhaps an
> > > additional sdev flag you set on resume) but we would still miss the
> > > case where you really had powered off the drive and then changed
> > > the media ... if you can regard this as the user's problem, then we
> > > might have a solution.
> >
> > Indeed, I was going to make the same point.
> >
> > The only reasonable conclusion is that suspending these SD card
> > readers isn't safe unless they don't contain a card -- or maybe just
> > if the device file isn't open or mounted.
>
> For standard removable media, I could see issuing an eject before
> suspend to emphasize the point.

That's not a workable approach in general. For example, you wouldn't
want to eject a CD just because it hadn't been used for a couple of
minutes and the drive was therefore about to be suspended.

> However, sd cards don't work like that
> ... they're not ejectable except manually and mostly used as the HDD of
> embedded, so the 99% use case is that the user will suspend and resume
> the device with the same sdd insert. It does sound like a use case we
> should support.

Agreed.

> > Although support for this sort of thing could be added to the
> > kernel, for now it's best to rely on userspace doing the right
> > thing. The kernel doesn't even know which devices suffer from this
> > problem.
>
> Can we solve from userspace the case where the user hasn't changed the
> media and the resume fails because we don't know?

The difficulty is recognizing situations where the media really was
changed while the device was suspended. Most devices, AFAIK, don't have
any problem with this, but card readers often do.

I suppose the kernel could just rely on users not to change media in
drives while they are mounted. Then any problems that arise would be
the users' fault. Yes, this is nothing more than passing the buck, but
it's hard to come up with any better approach. Doesn't Windows do
something like this?

Alan Stern