Re: [PATCH 1/5] scsi: Added a new macro in scsi_cmnd.h

Hannes Reinecke
2020-08-10T06:10:54Z

On 8/5/20 4:50 AM, Muneendra wrote:
> Added a new macro SCMD_NORETRIES_ABORT in scsi_cmnd.h
>
It's not a macro, it's a definition.

> The SCMD_NORETRIES_ABORT macro defines the third bit postion
> in scmd->state
>
> Signed-off-by: Muneendra <muneendra.kumar@broadcom.com>
> ---
> include/scsi/scsi_cmnd.h | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/include/scsi/scsi_cmnd.h b/include/scsi/scsi_cmnd.h
> index e76bac4..e1883fe 100644
> --- a/include/scsi/scsi_cmnd.h
> +++ b/include/scsi/scsi_cmnd.h
> @@ -64,6 +64,9 @@ struct scsi_pointer {
> /* for scmd->state */
> #define SCMD_STATE_COMPLETE 0
> #define SCMD_STATE_INFLIGHT 1
> +#define SCMD_NORETRIES_ABORT 2 /* If this bit is set then there won't be any
> + * retries of scmd on abort success
> + */
>
> struct scsi_cmnd {
> struct scsi_request req;
>
Other than that:

Reviewed-by: Hannes Reinecke <hare@suse.de>

Cheers,

Hannes
--
Dr. Hannes Reinecke Teamlead Storage & Networking
hare@suse.de +49 911 74053 688
SUSE Software Solutions GmbH, Maxfeldstr. 5, 90409 Nürnberg
HRB 36809 (AG Nürnberg), Geschäftsführer: Felix Imendörffer