From: James Bottomley <James.Bottomley@HansenPartnership.com>
To: Jim Gill <jgill@vmware.com>, pv-drivers@vmware.com
Cc: jejb@linux.ibj.com, martin.petersen@oracle.com,
linux-scsi@vger.kernel.org
Subject: Re: [PATCH 1/3 for-next] pvscsi: Use coherent memory instead of dma mapping sg lists
Date: Wed, 12 Aug 2020 13:59:33 -0700 [thread overview]
Message-ID: <1597265973.7293.50.camel@HansenPartnership.com> (raw)
In-Reply-To: <20200812205404.GA17846@petr-dev3.eng.vmware.com>
This is not the correct format for sending on behalf of someone else.
First there needs to be a from at the beginning separated by a blank
line identifying the Author:
From: Thomas Hellstrom <thellstrom@vmware.com>
On Wed, 2020-08-12 at 13:54 -0700, Jim Gill wrote:
> Use coherent memory instead of dma mapping sg lists each
> time they are used. This becomes important with SEV/swiotlb where
> dma mapping otherwise implies bouncing of the data. It also gets rid
> of a point of potential failure.
>
> Tested using a "bonnie++" run on an 8GB pvscsi disk on a
> swiotlb=force
> booted kernel.
>
> Signed-off-by: Thomas Hellstrom <thellstrom@vmware.com>
> [jgill@vmware.com: forwarding patch on behalf of thellstrom]
Then we don't need this because the From: at the beginning both
preserves the author information and makes it obvious
> Acked-by: jgill@vmware.com
And finally this needs to be a Signed-off-by: to comply with the DCO
section (c).
James
next prev parent reply other threads:[~2020-08-12 20:59 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-12 20:54 [PATCH 1/3 for-next] pvscsi: Use coherent memory instead of dma mapping sg lists Jim Gill
2020-08-12 20:59 ` James Bottomley [this message]
2020-08-13 7:28 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1597265973.7293.50.camel@HansenPartnership.com \
--to=james.bottomley@hansenpartnership.com \
--cc=jejb@linux.ibj.com \
--cc=jgill@vmware.com \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=pv-drivers@vmware.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox