From: James Bottomley <jejb@linux.ibm.com>
To: Kiwoong Kim <kwmad.kim@samsung.com>,
linux-scsi@vger.kernel.org, alim.akhtar@samsung.com,
avri.altman@wdc.com, martin.petersen@oracle.com,
beanhuo@micron.com, asutoshd@codeaurora.org, cang@codeaurora.org,
bvanassche@acm.org, grant.jung@samsung.com, sc.suh@samsung.com,
hy50.seo@samsung.com, sh425.lee@samsung.com
Subject: Re: [PATCH v4 1/2] ufs: introduce skipping manual flush for wb
Date: Tue, 08 Sep 2020 22:21:06 -0700 [thread overview]
Message-ID: <1599628866.10803.68.camel@linux.ibm.com> (raw)
In-Reply-To: <3cf3e93696510922b775d8887ca8408dd384648b.1599285983.git.kwmad.kim@samsung.com>
On Sat, 2020-09-05 at 15:06 +0900, Kiwoong Kim wrote:
[...]
> +
> + /*
> + * This quirk needs to disable manual flush for write booster
> + */
> + UFSHCI_QUIRK_SKIP_MANUAL_WB_FLUSH_CTRL = 1 << 11,
You can't have 1 << 11 it's already taken by:
8da76f71fef7 scsi: ufs-pci: Add quirk for broken auto-hibernate for Intel EHL
/*
* This quirk needs to disable manual flush for write booster
*/
UFSHCI_QUIRK_SKIP_MANUAL_WB_FLUSH_CTRL = 1 << 11,
I take it 1 << 12 is OK?
James
next prev parent reply other threads:[~2020-09-09 5:21 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20200905061548epcas2p1dc708a23247702c6b1f6c0eedc513a92@epcas2p1.samsung.com>
2020-09-05 6:06 ` [PATCH v4 0/2] ufs: introduce skipping manual flush for wb Kiwoong Kim
2020-09-05 6:06 ` [PATCH v4 1/2] " Kiwoong Kim
2020-09-09 5:21 ` James Bottomley [this message]
2020-09-09 6:24 ` Kiwoong Kim
2020-09-05 6:06 ` [PATCH v4 2/2] ufs: exynos: enable UFSHCI_QUIRK_SKIP_MANUAL_WB_FLUSH_CTRL Kiwoong Kim
2020-09-08 16:11 ` [PATCH v4 0/2] ufs: introduce skipping manual flush for wb Asutosh Das (asd)
2020-09-09 2:17 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1599628866.10803.68.camel@linux.ibm.com \
--to=jejb@linux.ibm.com \
--cc=alim.akhtar@samsung.com \
--cc=asutoshd@codeaurora.org \
--cc=avri.altman@wdc.com \
--cc=beanhuo@micron.com \
--cc=bvanassche@acm.org \
--cc=cang@codeaurora.org \
--cc=grant.jung@samsung.com \
--cc=hy50.seo@samsung.com \
--cc=kwmad.kim@samsung.com \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=sc.suh@samsung.com \
--cc=sh425.lee@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox