From: Bart Van Assche <bvanassche@acm.org>
To: Arnd Bergmann <arnd@kernel.org>,
"James E.J. Bottomley" <jejb@linux.ibm.com>,
"Martin K. Petersen" <martin.petersen@oracle.com>
Cc: Arnd Bergmann <arnd@arndb.de>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] scsi: stex: fix MU_MAX_DELAY typecheck
Date: Tue, 17 Jan 2023 09:43:03 -0800 [thread overview]
Message-ID: <15f1424c-d979-6330-843c-d5ea84a8bfac@acm.org> (raw)
In-Reply-To: <20230117163834.1053763-1-arnd@kernel.org>
On 1/17/23 08:38, Arnd Bergmann wrote:
> @@ -173,7 +173,7 @@ enum {
> ST_ADDITIONAL_MEM_MIN = 0x80000,
> PMIC_SHUTDOWN = 0x0D,
> PMIC_REUMSE = 0x10,
> - ST_IGNORED = -1,
> + ST_IGNORED = -1u,
> ST_NOTHANDLED = 7,
> ST_S3 = 3,
> ST_S4 = 4,
From drivers/scsi/stex.c:
int st_sleep_mic;
... st_sleep_mic == ST_IGNORED ...
Can changing ST_IGNORED from signed to unsigned break the stex driver?
Thanks,
Bart.
prev parent reply other threads:[~2023-01-17 17:55 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-17 16:38 [PATCH] scsi: stex: fix MU_MAX_DELAY typecheck Arnd Bergmann
2023-01-17 17:43 ` Bart Van Assche [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=15f1424c-d979-6330-843c-d5ea84a8bfac@acm.org \
--to=bvanassche@acm.org \
--cc=arnd@arndb.de \
--cc=arnd@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=jejb@linux.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox