Re: [PATCH] scsi: ufs: Correct the lun used in eh_device_reset_handler() callback

Can Guo
2020-12-30T07:50:28Z

On 2020-12-30 15:20, Avri Altman wrote:
>> Users can initiate resets to specific SCSI device/target/host through
>> IOCTL. When this happens, the SCSI cmd passed to eh_device/target/host
>> _reset_handler() callbacks is initialized with a request whose tag is
>> -1.
>> So, in this case, it is not right for eh_device_reset_handler()
>> callback
>> to count on the lun get from hba->lrb[-1]. Fix it by getting lun from
>> the
>> SCSI device associated with the SCSI cmd.
>>
>> Signed-off-by: Can Guo <cang@codeaurora.org>
> Reviewed-by: Avri Altman <avri.altman@wdc.com>
>
> Btw, am surprised to see that you guys are still using sg_reset
> instead of ufs-utils?

Hi Avri,

We are not using any user layer tools at all. But I am confronted
with many customers and tons of test teams inside and outside.
I see all kinds of corner cases everyday, so not surprised at all.

Thanks,
Can Guo

>
> Thanks,
> Avri