From: Ziqi Chen <ziqichen@codeaurora.org>
To: asutoshd@codeaurora.org, nguyenb@codeaurora.org,
cang@codeaurora.org, hongwus@codeaurora.org,
rnayak@codeaurora.org, vinholikatti@gmail.com,
jejb@linux.vnet.ibm.com, martin.petersen@oracle.com,
linux-scsi@vger.kernel.org, kernel-team@android.com,
saravanak@google.com, salyzyn@google.com,
ziqichen@codeaurora.org, kwmad.kim@samsung.com,
stanley.chu@mediatek.com
Subject: [PATCH v5 0/2] Two changes to fix ufs power down/on specs violation
Date: Fri, 8 Jan 2021 15:28:02 +0800 [thread overview]
Message-ID: <1610090885-50099-1-git-send-email-ziqichen@codeaurora.org> (raw)
This series is made based on 5.11-scsi-staging branch.
As per specs, e.g, JESD220E chapter 7.2, while powering off/on the ufs device, RST_N signal and REF_CLK signal
should be between VSS(Ground) and VCCQ/VCCQ2. The sequence after fixing as below:
Power down:
1. Assert RST_N low
2. Turn-off REF_CLK
3. Turn-off VCC
4. Turn-off VCCQ/VCCQ2.
power on:
1. Turn-on VCC
2. Turn-on VCCQ/VCCQ2
3. Turn-On REF_CLK
4. Deassert RST_N high.
The 1st change let ref-clk to be disabled before VCC & VCCQ turning off while to be enabled after VCC & VCCQ turning on.
The 2nd change is used to pull down RST_n during UFS power off.
Change since v4:
- Split the original change "scsi: ufs: Fix ufs power down/on specs violation" into two changes, one fixs clk specs violation and the other one fixs RST_n specs violation.
- The 2nd change is just only for QCOM platform.
Change since v3:
- Rename vops callback func toggle_device_reset(sturct ufs_hba *hba, bool down) to device_reset(sturct ufs_hba *hba, bool assert).
- Move the dealy after pulling donw RST_n back into vops.
Change since v2:
- Correct commit message.
Change since v1:
- Rename vops callback func device_reset(sturct ufs_hba *hba) to toggle_device_reset(sturct ufs_hba *hba, bool down) to fix this specs violation for all SoC vendors platform.
Ziqi Chen (2):
scsi: ufs: Fix ufs clk specs violation
scsi: ufs-qcom: Fix ufs RST_n specs violation
drivers/scsi/ufs/ufs-qcom.c | 4 ++++
drivers/scsi/ufs/ufshcd.c | 20 ++++++++++----------
2 files changed, 14 insertions(+), 10 deletions(-)
--
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project
next reply other threads:[~2021-01-08 7:29 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-08 7:28 Ziqi Chen [this message]
2021-01-08 7:28 ` [PATCH v5 1/2] scsi: ufs: Fix ufs clk specs violation Ziqi Chen
2021-01-08 8:23 ` Can Guo
2021-01-08 7:28 ` [PATCH v5 2/2] scsi: ufs-qcom: Fix ufs RST_n " Ziqi Chen
2021-01-08 8:05 ` Can Guo
2021-01-08 8:15 ` ziqichen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1610090885-50099-1-git-send-email-ziqichen@codeaurora.org \
--to=ziqichen@codeaurora.org \
--cc=asutoshd@codeaurora.org \
--cc=cang@codeaurora.org \
--cc=hongwus@codeaurora.org \
--cc=jejb@linux.vnet.ibm.com \
--cc=kernel-team@android.com \
--cc=kwmad.kim@samsung.com \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=nguyenb@codeaurora.org \
--cc=rnayak@codeaurora.org \
--cc=salyzyn@google.com \
--cc=saravanak@google.com \
--cc=stanley.chu@mediatek.com \
--cc=vinholikatti@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox