* [PATCH] scsi: qla2xxx: Simplify the calculation of variables
@ 2021-01-26 8:42 Jiapeng Zhong
2021-01-27 20:01 ` Himanshu Madhani
2021-01-29 18:34 ` Martin K. Petersen
0 siblings, 2 replies; 6+ messages in thread
From: Jiapeng Zhong @ 2021-01-26 8:42 UTC (permalink / raw)
To: njavali
Cc: GR-QLogic-Storage-Upstream, jejb, martin.petersen, linux-scsi,
linux-kernel, Jiapeng Zhong
Fix the following coccicheck warnings:
./drivers/scsi/qla2xxx/qla_nvme.c:288:24-26: WARNING !A || A && B is
equivalent to !A || B.
Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Signed-off-by: Jiapeng Zhong <abaci-bugfix@linux.alibaba.com>
---
drivers/scsi/qla2xxx/qla_nvme.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/scsi/qla2xxx/qla_nvme.c b/drivers/scsi/qla2xxx/qla_nvme.c
index eab559b..38196b2 100644
--- a/drivers/scsi/qla2xxx/qla_nvme.c
+++ b/drivers/scsi/qla2xxx/qla_nvme.c
@@ -285,7 +285,7 @@ static int qla_nvme_ls_req(struct nvme_fc_local_port *lport,
srb_t *sp;
- if (!fcport || (fcport && fcport->deleted))
+ if (!fcport || fcport->deleted)
return rval;
vha = fcport->vha;
--
1.8.3.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] scsi: qla2xxx: Simplify the calculation of variables
2021-01-26 8:42 [PATCH] scsi: qla2xxx: Simplify the calculation of variables Jiapeng Zhong
@ 2021-01-27 20:01 ` Himanshu Madhani
2021-01-29 18:34 ` Martin K. Petersen
1 sibling, 0 replies; 6+ messages in thread
From: Himanshu Madhani @ 2021-01-27 20:01 UTC (permalink / raw)
To: Jiapeng Zhong
Cc: Nilesh Javali, GR-QLogic-Storage-Upstream, James E.J. Bottomley,
Martin Petersen, linux-scsi@vger.kernel.org,
linux-kernel@vger.kernel.org
> On Jan 26, 2021, at 2:42 AM, Jiapeng Zhong <abaci-bugfix@linux.alibaba.com> wrote:
>
> Fix the following coccicheck warnings:
>
> ./drivers/scsi/qla2xxx/qla_nvme.c:288:24-26: WARNING !A || A && B is
> equivalent to !A || B.
>
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Signed-off-by: Jiapeng Zhong <abaci-bugfix@linux.alibaba.com>
> ---
> drivers/scsi/qla2xxx/qla_nvme.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/scsi/qla2xxx/qla_nvme.c b/drivers/scsi/qla2xxx/qla_nvme.c
> index eab559b..38196b2 100644
> --- a/drivers/scsi/qla2xxx/qla_nvme.c
> +++ b/drivers/scsi/qla2xxx/qla_nvme.c
> @@ -285,7 +285,7 @@ static int qla_nvme_ls_req(struct nvme_fc_local_port *lport,
> srb_t *sp;
>
>
> - if (!fcport || (fcport && fcport->deleted))
> + if (!fcport || fcport->deleted)
> return rval;
>
> vha = fcport->vha;
> --
> 1.8.3.1
>
Reviewed-by: Himanshu Madhani <himanshu.madhani@oracle.com>
--
Himanshu Madhani Oracle Linux Engineering
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] scsi: qla2xxx: Simplify the calculation of variables
2021-01-26 8:42 [PATCH] scsi: qla2xxx: Simplify the calculation of variables Jiapeng Zhong
2021-01-27 20:01 ` Himanshu Madhani
@ 2021-01-29 18:34 ` Martin K. Petersen
1 sibling, 0 replies; 6+ messages in thread
From: Martin K. Petersen @ 2021-01-29 18:34 UTC (permalink / raw)
To: Jiapeng Zhong
Cc: njavali, GR-QLogic-Storage-Upstream, jejb, martin.petersen,
linux-scsi, linux-kernel
Jiapeng,
> Fix the following coccicheck warnings:
>
> ./drivers/scsi/qla2xxx/qla_nvme.c:288:24-26: WARNING !A || A && B is
> equivalent to !A || B.
Applied to 5.12/scsi-staging, thanks!
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] scsi: qla2xxx: Simplify the calculation of variables
@ 2021-02-03 2:26 Jiapeng Chong
2021-02-03 16:13 ` Himanshu Madhani
0 siblings, 1 reply; 6+ messages in thread
From: Jiapeng Chong @ 2021-02-03 2:26 UTC (permalink / raw)
To: njavali
Cc: GR-QLogic-Storage-Upstream, jejb, martin.petersen, linux-scsi,
linux-kernel, Jiapeng Chong
Fix the following coccicheck warnings:
./drivers/scsi/qla2xxx/qla_target.c:984:12-14: WARNING !A || A && B is
equivalent to !A || B.
Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
---
drivers/scsi/qla2xxx/qla_target.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/scsi/qla2xxx/qla_target.c b/drivers/scsi/qla2xxx/qla_target.c
index 0d09480..c48daf5 100644
--- a/drivers/scsi/qla2xxx/qla_target.c
+++ b/drivers/scsi/qla2xxx/qla_target.c
@@ -981,8 +981,7 @@ void qlt_free_session_done(struct work_struct *work)
int rc;
if (!own ||
- (own &&
- (own->iocb.u.isp24.status_subcode == ELS_PLOGI))) {
+ (own->iocb.u.isp24.status_subcode == ELS_PLOGI)) {
rc = qla2x00_post_async_logout_work(vha, sess,
NULL);
if (rc != QLA_SUCCESS)
--
1.8.3.1
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH] scsi: qla2xxx: Simplify the calculation of variables
2021-02-03 2:26 Jiapeng Chong
@ 2021-02-03 16:13 ` Himanshu Madhani
0 siblings, 0 replies; 6+ messages in thread
From: Himanshu Madhani @ 2021-02-03 16:13 UTC (permalink / raw)
To: Jiapeng Chong
Cc: njavali@marvell.com, GR-QLogic-Storage-Upstream@marvell.com,
jejb@linux.ibm.com, Martin Petersen, linux-scsi@vger.kernel.org,
linux-kernel@vger.kernel.org
> On Feb 2, 2021, at 8:26 PM, Jiapeng Chong <jiapeng.chong@linux.alibaba.com> wrote:
>
> Fix the following coccicheck warnings:
>
> ./drivers/scsi/qla2xxx/qla_target.c:984:12-14: WARNING !A || A && B is
> equivalent to !A || B.
>
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
> ---
> drivers/scsi/qla2xxx/qla_target.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/scsi/qla2xxx/qla_target.c b/drivers/scsi/qla2xxx/qla_target.c
> index 0d09480..c48daf5 100644
> --- a/drivers/scsi/qla2xxx/qla_target.c
> +++ b/drivers/scsi/qla2xxx/qla_target.c
> @@ -981,8 +981,7 @@ void qlt_free_session_done(struct work_struct *work)
> int rc;
>
> if (!own ||
> - (own &&
> - (own->iocb.u.isp24.status_subcode == ELS_PLOGI))) {
> + (own->iocb.u.isp24.status_subcode == ELS_PLOGI)) {
> rc = qla2x00_post_async_logout_work(vha, sess,
> NULL);
> if (rc != QLA_SUCCESS)
> --
> 1.8.3.1
>
Looks Good.
Reviewed-by: Himanshu Madhani <himanshu.madhani@oracle.com>
--
Himanshu Madhani Oracle Linux Engineering
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] scsi: qla2xxx: Simplify the calculation of variables
@ 2022-06-16 1:21 Jiapeng Chong
0 siblings, 0 replies; 6+ messages in thread
From: Jiapeng Chong @ 2022-06-16 1:21 UTC (permalink / raw)
To: njavali
Cc: GR-QLogic-Storage-Upstream, jejb, martin.petersen, linux-scsi,
linux-kernel, Jiapeng Chong, Abaci Robot
This was found by coccicheck:
./drivers/scsi/qla2xxx/qla_target.c:1031:20-22: WARNING !A || A && B is equivalent to !A || B.
Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
---
drivers/scsi/qla2xxx/qla_target.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/scsi/qla2xxx/qla_target.c b/drivers/scsi/qla2xxx/qla_target.c
index 2b2f68288375..0dc9ca3c9509 100644
--- a/drivers/scsi/qla2xxx/qla_target.c
+++ b/drivers/scsi/qla2xxx/qla_target.c
@@ -1028,8 +1028,7 @@ void qlt_free_session_done(struct work_struct *work)
}
if (ha->flags.edif_enabled &&
- (!own || (own &&
- own->iocb.u.isp24.status_subcode == ELS_PLOGI))) {
+ (!own || own->iocb.u.isp24.status_subcode == ELS_PLOGI)) {
sess->edif.authok = 0;
if (!ha->flags.host_shutting_down) {
ql_dbg(ql_dbg_edif, vha, 0x911e,
--
2.20.1.7.g153144c
^ permalink raw reply related [flat|nested] 6+ messages in thread
end of thread, other threads:[~2022-06-16 1:21 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-01-26 8:42 [PATCH] scsi: qla2xxx: Simplify the calculation of variables Jiapeng Zhong
2021-01-27 20:01 ` Himanshu Madhani
2021-01-29 18:34 ` Martin K. Petersen
-- strict thread matches above, loose matches on Subject: below --
2021-02-03 2:26 Jiapeng Chong
2021-02-03 16:13 ` Himanshu Madhani
2022-06-16 1:21 Jiapeng Chong
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox