* [PATCH -next] scsi: ufs-mediatek: Add missing of_node_put() in ufs_mtk_probe()
@ 2021-06-17 11:32 Zou Wei
2021-06-18 1:16 ` Stanley Chu
2021-06-19 2:48 ` Martin K. Petersen
0 siblings, 2 replies; 3+ messages in thread
From: Zou Wei @ 2021-06-17 11:32 UTC (permalink / raw)
To: stanley.chu, alim.akhtar, avri.altman, jejb, martin.petersen,
matthias.bgg
Cc: linux-scsi, linux-mediatek, linux-kernel, linux-arm-kernel,
Zou Wei
The function is missing a of_node_put on node, fix this by adding the call
before returning.
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Zou Wei <zou_wei@huawei.com>
---
drivers/scsi/ufs/ufs-mediatek.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/scsi/ufs/ufs-mediatek.c b/drivers/scsi/ufs/ufs-mediatek.c
index 1a517c9..d2c2516 100644
--- a/drivers/scsi/ufs/ufs-mediatek.c
+++ b/drivers/scsi/ufs/ufs-mediatek.c
@@ -1120,6 +1120,7 @@ static int ufs_mtk_probe(struct platform_device *pdev)
if (err)
dev_info(dev, "probe failed %d\n", err);
+ of_node_put(reset_node);
return err;
}
--
2.6.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH -next] scsi: ufs-mediatek: Add missing of_node_put() in ufs_mtk_probe()
2021-06-17 11:32 [PATCH -next] scsi: ufs-mediatek: Add missing of_node_put() in ufs_mtk_probe() Zou Wei
@ 2021-06-18 1:16 ` Stanley Chu
2021-06-19 2:48 ` Martin K. Petersen
1 sibling, 0 replies; 3+ messages in thread
From: Stanley Chu @ 2021-06-18 1:16 UTC (permalink / raw)
To: Zou Wei
Cc: alim.akhtar, avri.altman, jejb, martin.petersen, matthias.bgg,
linux-scsi, linux-mediatek, linux-kernel, linux-arm-kernel,
peter.wang
Hi Zou,
On Thu, 2021-06-17 at 19:32 +0800, Zou Wei wrote:
> The function is missing a of_node_put on node, fix this by adding the call
> before returning.
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Zou Wei <zou_wei@huawei.com>
> ---
> drivers/scsi/ufs/ufs-mediatek.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/scsi/ufs/ufs-mediatek.c b/drivers/scsi/ufs/ufs-mediatek.c
> index 1a517c9..d2c2516 100644
> --- a/drivers/scsi/ufs/ufs-mediatek.c
> +++ b/drivers/scsi/ufs/ufs-mediatek.c
> @@ -1120,6 +1120,7 @@ static int ufs_mtk_probe(struct platform_device *pdev)
> if (err)
> dev_info(dev, "probe failed %d\n", err);
>
> + of_node_put(reset_node);
> return err;
> }
>
Thanks for this fix.
Reviewed-by: Stanley Chu <stanley.chu@mediatek.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH -next] scsi: ufs-mediatek: Add missing of_node_put() in ufs_mtk_probe()
2021-06-17 11:32 [PATCH -next] scsi: ufs-mediatek: Add missing of_node_put() in ufs_mtk_probe() Zou Wei
2021-06-18 1:16 ` Stanley Chu
@ 2021-06-19 2:48 ` Martin K. Petersen
1 sibling, 0 replies; 3+ messages in thread
From: Martin K. Petersen @ 2021-06-19 2:48 UTC (permalink / raw)
To: Zou Wei
Cc: stanley.chu, alim.akhtar, avri.altman, jejb, martin.petersen,
matthias.bgg, linux-scsi, linux-mediatek, linux-kernel,
linux-arm-kernel
Zou,
> The function is missing a of_node_put on node, fix this by adding the
> call before returning.
Applied to 5.14/scsi-staging, thanks!
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-06-19 2:49 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-06-17 11:32 [PATCH -next] scsi: ufs-mediatek: Add missing of_node_put() in ufs_mtk_probe() Zou Wei
2021-06-18 1:16 ` Stanley Chu
2021-06-19 2:48 ` Martin K. Petersen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox