RE: [PATCH 09/10] megaraid_sas: swap whole register in megasas_register_aen

[Sumit Saxena <sumit.saxena@avagotech.com>]

>-----Original Message-----
>From: Christoph Hellwig [mailto:hch@lst.de]
>Sent: Saturday, January 10, 2015 10:41 PM
>To: Sumit.Saxena@avagotech.com; kashyap.desai@avagotech.com
>Cc: martin.petersen@oracle.com; linux-scsi@vger.kernel.org
>Subject: [PATCH 09/10] megaraid_sas: swap whole register in
>megasas_register_aen
>
>Swap the whole 32 bits we read from the hardware instead of swapping just
>the 16bits we care about in place later.
>
>Signed-off-by: Christoph Hellwig <hch@lst.de>
>---
> drivers/scsi/megaraid/megaraid_sas_base.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
>diff --git a/drivers/scsi/megaraid/megaraid_sas_base.c
>b/drivers/scsi/megaraid/megaraid_sas_base.c
>index 5350e18..3d4a080 100644
>--- a/drivers/scsi/megaraid/megaraid_sas_base.c
>+++ b/drivers/scsi/megaraid/megaraid_sas_base.c
>@@ -4882,8 +4882,9 @@ megasas_register_aen(struct megasas_instance
>*instance, u32 seq_num,
>
> 	if (instance->aen_cmd) {
>
>-		prev_aen.word = instance->aen_cmd->frame-
>>dcmd.mbox.w[1];
>-		prev_aen.members.locale =
>le16_to_cpu(prev_aen.members.locale);
>+		prev_aen.word =
>+			le32_to_cpu(instance->aen_cmd->frame-
>>dcmd.mbox.w[1]);
>+		prev_aen.members.locale = prev_aen.members.locale;
>
> 		/*
> 		 * A class whose enum value is smaller is inclusive of all

Looks good to me.
Acked-by: Sumit Saxena <sumit.saxena@avagotech.com>

>--
>1.9.1