* [PATCH][v2] qed: Fix compilation for CONFIG_QED_SRIOV undefined scenario
@ 2021-10-07 15:52 Prabhakar Kushwaha
2021-10-08 16:30 ` patchwork-bot+netdevbpf
0 siblings, 1 reply; 2+ messages in thread
From: Prabhakar Kushwaha @ 2021-10-07 15:52 UTC (permalink / raw)
To: netdev, davem, kuba
Cc: linux-rdma, linux-scsi, martin.petersen, aelior, smalin, jhasan,
mrangankar, pkushwaha, prabhakar.pkin, malin1024, naresh.kamboju,
Omkar Kulkarni
This patch fixes below compliation error in case CONFIG_QED_SRIOV not
defined.
drivers/net/ethernet/qlogic/qed/qed_dev.c: In function
‘qed_fw_err_handler’:
drivers/net/ethernet/qlogic/qed/qed_dev.c:2390:3: error: implicit
declaration of function ‘qed_sriov_vfpf_malicious’; did you mean
‘qed_iov_vf_task’? [-Werror=implicit-function-declaration]
qed_sriov_vfpf_malicious(p_hwfn, &data->err_data);
^~~~~~~~~~~~~~~~~~~~~~~~
qed_iov_vf_task
drivers/net/ethernet/qlogic/qed/qed_dev.c: In function
‘qed_common_eqe_event’:
drivers/net/ethernet/qlogic/qed/qed_dev.c:2410:10: error: implicit
declaration of function ‘qed_sriov_eqe_event’; did you mean
‘qed_common_eqe_event’? [-Werror=implicit-function-declaration]
return qed_sriov_eqe_event(p_hwfn, opcode, echo, data,
^~~~~~~~~~~~~~~~~~~
qed_common_eqe_event
Fixes: fe40a830dcde ("qed: Update qed_hsi.h for fw 8.59.1.0")
Reported-by: Linux Kernel Functional Testing <lkft@linaro.org>
Cc: Naresh Kamboju <naresh.kamboju@linaro.org>
Signed-off-by: Ariel Elior <aelior@marvell.com>
Signed-off-by: Shai Malin <smalin@marvell.com>
Signed-off-by: Omkar Kulkarni <okulkarni@marvell.com>
Signed-off-by: Prabhakar Kushwaha <pkushwaha@marvell.com>
---
This patch is targeted for the repo
git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net-next.git
Changes for v2:
- Fixed patchwork's netdev/verify_fixes "error".
drivers/net/ethernet/qlogic/qed/qed_sriov.h | 12 ++++++++++++
1 file changed, 12 insertions(+)
diff --git a/drivers/net/ethernet/qlogic/qed/qed_sriov.h b/drivers/net/ethernet/qlogic/qed/qed_sriov.h
index 1edf9c44dc67..f448e3dd6c8b 100644
--- a/drivers/net/ethernet/qlogic/qed/qed_sriov.h
+++ b/drivers/net/ethernet/qlogic/qed/qed_sriov.h
@@ -478,6 +478,18 @@ static inline int qed_sriov_disable(struct qed_dev *cdev, bool pci_enabled)
static inline void qed_inform_vf_link_state(struct qed_hwfn *hwfn)
{
}
+
+static inline void qed_sriov_vfpf_malicious(struct qed_hwfn *p_hwfn,
+ struct fw_err_data *p_data)
+{
+}
+
+static inline int qed_sriov_eqe_event(struct qed_hwfn *p_hwfn, u8 opcode,
+ __le16 echo, union event_ring_data *data,
+ u8 fw_return_code)
+{
+ return 0;
+}
#endif
#define qed_for_each_vf(_p_hwfn, _i) \
--
2.24.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH][v2] qed: Fix compilation for CONFIG_QED_SRIOV undefined scenario
2021-10-07 15:52 [PATCH][v2] qed: Fix compilation for CONFIG_QED_SRIOV undefined scenario Prabhakar Kushwaha
@ 2021-10-08 16:30 ` patchwork-bot+netdevbpf
0 siblings, 0 replies; 2+ messages in thread
From: patchwork-bot+netdevbpf @ 2021-10-08 16:30 UTC (permalink / raw)
To: Prabhakar Kushwaha
Cc: netdev, davem, kuba, linux-rdma, linux-scsi, martin.petersen,
aelior, smalin, jhasan, mrangankar, prabhakar.pkin, malin1024,
naresh.kamboju, okulkarni
Hello:
This patch was applied to netdev/net-next.git (master)
by David S. Miller <davem@davemloft.net>:
On Thu, 7 Oct 2021 18:52:38 +0300 you wrote:
> This patch fixes below compliation error in case CONFIG_QED_SRIOV not
> defined.
> drivers/net/ethernet/qlogic/qed/qed_dev.c: In function
> ‘qed_fw_err_handler’:
> drivers/net/ethernet/qlogic/qed/qed_dev.c:2390:3: error: implicit
> declaration of function ‘qed_sriov_vfpf_malicious’; did you mean
> ‘qed_iov_vf_task’? [-Werror=implicit-function-declaration]
> qed_sriov_vfpf_malicious(p_hwfn, &data->err_data);
> ^~~~~~~~~~~~~~~~~~~~~~~~
> qed_iov_vf_task
> drivers/net/ethernet/qlogic/qed/qed_dev.c: In function
> ‘qed_common_eqe_event’:
> drivers/net/ethernet/qlogic/qed/qed_dev.c:2410:10: error: implicit
> declaration of function ‘qed_sriov_eqe_event’; did you mean
> ‘qed_common_eqe_event’? [-Werror=implicit-function-declaration]
> return qed_sriov_eqe_event(p_hwfn, opcode, echo, data,
> ^~~~~~~~~~~~~~~~~~~
> qed_common_eqe_event
>
> [...]
Here is the summary with links:
- [v2] qed: Fix compilation for CONFIG_QED_SRIOV undefined scenario
https://git.kernel.org/netdev/net-next/c/e761523d0b40
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-10-08 16:30 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-10-07 15:52 [PATCH][v2] qed: Fix compilation for CONFIG_QED_SRIOV undefined scenario Prabhakar Kushwaha
2021-10-08 16:30 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox