Re: [PATCH 4/4] scsi: hisi_sas: Use libsas internal abort support

John Garry
2022-03-04T09:48:12Z

On 03/03/2022 16:42, Damien Le Moal wrote:
>> - if (DEV_IS_GONE(sas_dev)) {
>> - if (sas_dev)
>> - dev_info(dev, "task prep: device %d not ready\n",
>> - sas_dev->device_id);
>> - else
>> - dev_info(dev, "task prep: device %016llx not ready\n",
>> - SAS_ADDR(device->sas_addr));
>> + if (DEV_IS_GONE(sas_dev)) {
>> + if (sas_dev)
>> + dev_info(dev, "task prep: device %d not ready\n",
>> + sas_dev->device_id);
>> + else
>> + dev_info(dev, "task prep: device %016llx not ready\n",
>> + SAS_ADDR(device->sas_addr));
>>
> This blank line could be removed too, no ?

I think that I might change this code to just use the 2nd print always.

>
>> - return -ECOMM;
>> - }
>> + return -ECOMM;
>> + }
>>
>> - if (task->uldd_task) {
>> - struct ata_queued_cmd *qc;
>> + port = to_hisi_sas_port(sas_port);
>> + if (!port->port_attached) {
>> + dev_info(dev, "task prep: %s port%d not attach device\n",
>> + dev_is_sata(device) ? "SATA/STP" : "SAS",
>> + device->port->id);
>>
>> - if (dev_is_sata(device)) {
>> - qc = task->uldd_task;
>> - scmd = qc->scsicmd;
>> - } else {
>> - scmd = task->uldd_task;
>> + return -ECOMM;
> One tab too many for the indentation here, no ?

Right, I'll fix it.

Thanks,
John