public inbox for linux-scsi@vger.kernel.org
 help / color / mirror / Atom feed
From: John Garry <john.garry@huawei.com>
To: <jejb@linux.ibm.com>, <martin.petersen@oracle.com>,
	<jinpu.wang@cloud.ionos.com>, <damien.lemoal@opensource.wdc.com>
Cc: <linux-scsi@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	<linuxarm@huawei.com>, <yangxingui@huawei.com>,
	<niklas.cassel@wdc.com>, "John Garry" <john.garry@huawei.com>
Subject: [PATCH v6 8/8] scsi: libsas: Update SATA dev FIS in sas_ata_task_done()
Date: Mon, 17 Oct 2022 17:20:35 +0800	[thread overview]
Message-ID: <1665998435-199946-9-git-send-email-john.garry@huawei.com> (raw)
In-Reply-To: <1665998435-199946-1-git-send-email-john.garry@huawei.com>

In sas_ata_task_done(), for commands which complete with error we set
the SATA dev FIS status field with ATA_ERR. In ata_eh_analyze_tf() this
would be interpreted as a HSM error. Set ATA_DRDY, which will lead libata
to judge as a device error, which is a safer bet.

Signed-off-by: John Garry <john.garry@huawei.com>
---
 drivers/scsi/libsas/sas_ata.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/scsi/libsas/sas_ata.c b/drivers/scsi/libsas/sas_ata.c
index 61f64d54e67d..78e6046fb55a 100644
--- a/drivers/scsi/libsas/sas_ata.c
+++ b/drivers/scsi/libsas/sas_ata.c
@@ -139,8 +139,8 @@ static void sas_ata_task_done(struct sas_task *task)
 				qc->flags |= ATA_QCFLAG_FAILED;
 			}
 
-			dev->sata_dev.fis[3] = 0x04; /* status err */
-			dev->sata_dev.fis[2] = ATA_ERR;
+			dev->sata_dev.fis[2] = ATA_ERR | ATA_DRDY; /* tf status */
+			dev->sata_dev.fis[3] = ATA_ABORTED; /* tf error */
 		}
 	}
 
-- 
2.35.3


  parent reply	other threads:[~2022-10-17  8:51 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-17  9:20 [PATCH v6 0/8] libsas and drivers: NCQ error handling John Garry
2022-10-17  9:20 ` [PATCH v6 1/8] scsi: libsas: Add sas_ata_device_link_abort() John Garry
2022-10-17 10:52   ` Niklas Cassel
2022-10-17 10:57     ` John Garry
2022-10-17  9:20 ` [PATCH v6 2/8] scsi: hisi_sas: Move slot variable definition in hisi_sas_abort_task() John Garry
2022-10-17  9:20 ` [PATCH v6 3/8] scsi: hisi_sas: Add SATA_DISK_ERR bit handling for v3 hw John Garry
2022-10-17  9:20 ` [PATCH v6 4/8] scsi: hisi_sas: Modify v3 HW SATA disk error state completion processing John Garry
2022-10-17 10:45   ` Niklas Cassel
2022-10-17 11:01     ` John Garry
2022-10-17  9:20 ` [PATCH v6 5/8] scsi: pm8001: Modify task abort handling for SATA task John Garry
2022-10-17  9:20 ` [PATCH v6 6/8] scsi: pm8001: Use sas_ata_device_link_abort() to handle NCQ errors John Garry
2022-10-17  9:01   ` Jinpu Wang
2022-10-17  9:20 ` [PATCH v6 7/8] scsi: libsas: Make sas_{alloc, alloc_slow, free}_task() private John Garry
2022-10-17  9:20 ` John Garry [this message]
2022-10-17 10:41   ` [PATCH v6 8/8] scsi: libsas: Update SATA dev FIS in sas_ata_task_done() Niklas Cassel
2022-10-18  2:40 ` [PATCH v6 0/8] libsas and drivers: NCQ error handling Martin K. Petersen
2022-10-22  3:52 ` Martin K. Petersen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1665998435-199946-9-git-send-email-john.garry@huawei.com \
    --to=john.garry@huawei.com \
    --cc=damien.lemoal@opensource.wdc.com \
    --cc=jejb@linux.ibm.com \
    --cc=jinpu.wang@cloud.ionos.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=linuxarm@huawei.com \
    --cc=martin.petersen@oracle.com \
    --cc=niklas.cassel@wdc.com \
    --cc=yangxingui@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox