public inbox for linux-scsi@vger.kernel.org
 help / color / mirror / Atom feed
From: Arthur Simchaev <Arthur.Simchaev@wdc.com>
To: martin.petersen@oracle.com
Cc: avri.altman@wdc.com, Avi.Shchislowski@wdc.com,
	beanhuo@micron.com, linux-kernel@vger.kernel.org,
	linux-scsi@vger.kernel.org,
	Arthur Simchaev <Arthur.Simchaev@wdc.com>
Subject: [PATCH 1/4] ufs: core: Remove redundant wb check
Date: Mon, 31 Oct 2022 18:25:21 +0200	[thread overview]
Message-ID: <1667233524-13715-2-git-send-email-Arthur.Simchaev@wdc.com> (raw)
In-Reply-To: <1667233524-13715-1-git-send-email-Arthur.Simchaev@wdc.com>

We used to use the extended-feature field in the device descriptor,
as an indication that the device supports ufs2.2 or later.
Remove that as this check is specifically done few lines above.

Signed-off-by: Arthur Simchaev <Arthur.Simchaev@wdc.com>
---
 drivers/ufs/core/ufshcd.c | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/drivers/ufs/core/ufshcd.c b/drivers/ufs/core/ufshcd.c
index ee73d70..de4e7e7 100644
--- a/drivers/ufs/core/ufshcd.c
+++ b/drivers/ufs/core/ufshcd.c
@@ -7574,10 +7574,6 @@ static void ufshcd_wb_probe(struct ufs_hba *hba, const u8 *desc_buf)
 	     (hba->dev_quirks & UFS_DEVICE_QUIRK_SUPPORT_EXTENDED_FEATURES)))
 		goto wb_disabled;
 
-	if (hba->desc_size[QUERY_DESC_IDN_DEVICE] <
-	    DEVICE_DESC_PARAM_EXT_UFS_FEATURE_SUP + 4)
-		goto wb_disabled;
-
 	ext_ufs_feature = get_unaligned_be32(desc_buf +
 					DEVICE_DESC_PARAM_EXT_UFS_FEATURE_SUP);
 
-- 
2.7.4


  reply	other threads:[~2022-10-31 16:25 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-31 16:25 [PATCH 0/4] ufs: core: Always read the descriptors with max length Arthur Simchaev
2022-10-31 16:25 ` Arthur Simchaev [this message]
2022-10-31 16:25 ` [PATCH 2/4] ufs: core: Remove redundant desc_size variable from hba Arthur Simchaev
2022-10-31 16:25 ` [PATCH 3/4] ufs: core: Remove len parameter from ufshcd_set_active_icc_lvl Arthur Simchaev
2022-10-31 16:25 ` [PATCH 4/4] ufs: core: Remove ufshcd_map_desc_id_to_length function Arthur Simchaev
2022-11-01  1:51   ` kernel test robot
2022-11-01  8:45   ` kernel test robot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1667233524-13715-2-git-send-email-Arthur.Simchaev@wdc.com \
    --to=arthur.simchaev@wdc.com \
    --cc=Avi.Shchislowski@wdc.com \
    --cc=avri.altman@wdc.com \
    --cc=beanhuo@micron.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=martin.petersen@oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox