From: Bart Van Assche <bvanassche@acm.org>
To: "Peter Wang (王信友)" <peter.wang@mediatek.com>,
"linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
"jejb@linux.ibm.com" <jejb@linux.ibm.com>,
"avri.altman@sandisk.com" <avri.altman@sandisk.com>,
"alim.akhtar@samsung.com" <alim.akhtar@samsung.com>,
"martin.petersen@oracle.com" <martin.petersen@oracle.com>
Cc: "Alice Chao (趙珮均)" <Alice.Chao@mediatek.com>,
"Eddie Huang (黃智傑)" <eddie.huang@mediatek.com>,
"CC Chou (周志杰)" <cc.chou@mediatek.com>,
"Ed Tsai (蔡宗軒)" <Ed.Tsai@mediatek.com>,
wsd_upstream <wsd_upstream@mediatek.com>,
"Chaotian Jing (井朝天)" <Chaotian.Jing@mediatek.com>,
"Chun-Hung Wu (巫駿宏)" <Chun-hung.Wu@mediatek.com>,
"Naomi Chu (朱詠田)" <Naomi.Chu@mediatek.com>,
"linux-mediatek@lists.infradead.org"
<linux-mediatek@lists.infradead.org>,
"Tun-yu Yu (游敦聿)" <Tun-yu.Yu@mediatek.com>
Subject: Re: [PATCH v1] ufs: core: Avoid IRQ thread wakeup during active UIC command
Date: Thu, 5 Mar 2026 06:17:36 -0600 [thread overview]
Message-ID: <16a44a0c-1fcf-4e3a-bf9e-d29ca5f62157@acm.org> (raw)
In-Reply-To: <fa949b2c2f9d23fa112f8b37377ca2f23c5bb258.camel@mediatek.com>
On 3/4/26 9:27 PM, Peter Wang (王信友) wrote:
> The main reason is not context switch time.
> The problem is that a threaded IRQ handler can be preempted
> by a regular IRQ.
> When the system is busy, for example during kernel boot,
> there are many other module IRQs present in the system.
Spending 500 ms in interrupts without giving the CPU a chance to run is
excessive, isn't it? Anyway, if you really need this patch, please
mention the above information in the patch description and combine the
two if-statements into a single if-statement, e.g. as follows:
if ((!hba->mcq_enabled || !hba->mcq_esi_enabled) &&
!hba->active_uic_cmd)
...
Thanks,
Bart.
next prev parent reply other threads:[~2026-03-05 12:17 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-04 7:12 [PATCH v1] ufs: core: Avoid IRQ thread wakeup during active UIC command peter.wang
2026-03-04 14:43 ` Bart Van Assche
2026-03-05 3:27 ` Peter Wang (王信友)
2026-03-05 12:17 ` Bart Van Assche [this message]
2026-03-06 3:49 ` Peter Wang (王信友)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=16a44a0c-1fcf-4e3a-bf9e-d29ca5f62157@acm.org \
--to=bvanassche@acm.org \
--cc=Alice.Chao@mediatek.com \
--cc=Chaotian.Jing@mediatek.com \
--cc=Chun-hung.Wu@mediatek.com \
--cc=Ed.Tsai@mediatek.com \
--cc=Naomi.Chu@mediatek.com \
--cc=Tun-yu.Yu@mediatek.com \
--cc=alim.akhtar@samsung.com \
--cc=avri.altman@sandisk.com \
--cc=cc.chou@mediatek.com \
--cc=eddie.huang@mediatek.com \
--cc=jejb@linux.ibm.com \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=peter.wang@mediatek.com \
--cc=wsd_upstream@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox