Re: [PATCH] scsi: sd: call device_del() if device_add_disk() fails

Dan Carpenter
2022-03-31T16:25:13Z

On Thu, Mar 31, 2022 at 06:14:27PM +0200, Fabio M. De Francesco wrote:
> On gioved? 31 marzo 2022 15:42:10 CEST Dan Carpenter wrote:
> > Wenchao Hao, what you're saying makes a lot of sense but it raises a lot
> > of questions in turn.
> >
> > Fabio, did you test your patch?
>
> Yes, I did, Dan. I tested it the usual way with the "#syz test:" command.
> Obviously I have not the hardware to test code on it.
>

Yeah. What a nightmare. You posted a link to the first test. It said
passed but definitely introduced some use after frees but how was anyone
supposed to know?

No way we would have figured this out. I'm working to make Smatch
understand device_put() better but this one is way difficult.

Sorry that you went through this.

regards,
dan carpenter