From: Arnd Bergmann <arnd@arndb.de>
To: Ebru Akagunduz <ebru.akagunduz@gmail.com>
Cc: JBottomley@parallels.com, linux-scsi@vger.kernel.org,
linux-kernel@vger.kernel.org, opw-kernel@googlegroups.com
Subject: Re: [PATCH] scsi: ips.c: use 64-bit time types
Date: Wed, 08 Oct 2014 22:41:23 +0200 [thread overview]
Message-ID: <1790241.KrvEcO3C6i@wuerfel> (raw)
In-Reply-To: <1412799248-17181-1-git-send-email-ebru.akagunduz@gmail.com>
On Wednesday 08 October 2014 23:14:08 Ebru Akagunduz wrote:
> This patch changes 32-bit time types to 64-bit in
> ips.c
>
> time_t can only represent signed 32-bit dates but
> the driver should represent dates that are after
> January 2038.
>
> Use time64_t type instead of time_t.
>
> Signed-off-by: Ebru Akagunduz <ebru.akagunduz@gmail.com>
>
Hi Ebru,
I think you missed the location in which ffdc_time is initially
assigned, and wher it gets compared to the current time:
struct timeval tv;
do_gettimeofday(&tv);
ha->last_ffdc = tv.tv_sec;
This needs to be changed to timespec64 to actually avoid the
overflow problem. I think this one should also use monotonic time,
i.e. ktime_get_ts64 rather than getnstimeofday64.
Arnd
next prev parent reply other threads:[~2014-10-08 20:41 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-08 20:14 [PATCH] scsi: ips.c: use 64-bit time types Ebru Akagunduz
2014-10-08 20:41 ` Arnd Bergmann [this message]
2014-10-08 20:44 ` James Bottomley
2014-10-08 20:58 ` Arnd Bergmann
2014-10-09 13:40 ` James Bottomley
2014-10-09 14:29 ` Arnd Bergmann
2014-10-09 15:13 ` James Bottomley
2014-10-09 16:13 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1790241.KrvEcO3C6i@wuerfel \
--to=arnd@arndb.de \
--cc=JBottomley@parallels.com \
--cc=ebru.akagunduz@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=opw-kernel@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox