From: Bart Van Assche <bvanassche@acm.org>
To: Seunghwan Baek <sh8267.baek@samsung.com>,
linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org,
martin.petersen@oracle.com,
James.Bottomley@HansenPartnership.com, avri.altman@wdc.com,
alim.akhtar@samsung.com
Cc: grant.jung@samsung.com, jt77.jang@samsung.com,
junwoo80.lee@samsung.com, dh0421.hwang@samsung.com,
jangsub.yi@samsung.com, sh043.lee@samsung.com,
cw9316.lee@samsung.com, wkon.kim@samsung.com,
stable@vger.kernel.org
Subject: Re: [PATCH v1 1/1] ufs: core: set SDEV_OFFLINE when ufs shutdown.
Date: Tue, 24 Sep 2024 11:24:50 -0700 [thread overview]
Message-ID: <1845f326-e9eb-4351-9ed1-fce373c82cb0@acm.org> (raw)
In-Reply-To: <003201db0e27$df93f250$9ebbd6f0$@samsung.com>
On 9/23/24 7:17 PM, Seunghwan Baek wrote:> That's because SSU (Start
Stop Unit) command must be sent during
> shutdown process. If SDEV_OFFLINE is set for wlun, SSU command cannot
> be sent because it is rejected by the scsi layer. Therefore, we
> consider to set SDEV_QUIESCE for wlun, and set SDEV_OFFLINE for other
> lus.
Right. Since ufshcd_wl_shutdown() is expected to stop all DMA related to
the UFS host, shouldn't there be a scsi_device_quiesce(sdev) call after
the __ufshcd_wl_suspend(hba, UFS_SHUTDOWN_PM) call?
Thanks,
Bart.
next prev parent reply other threads:[~2024-09-24 18:25 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20240829093920epcas1p1cf45ac0cd7d4ed8cf39ff5f1d1b4fe00@epcas1p1.samsung.com>
2024-08-29 9:39 ` [PATCH v1 0/1] Set SDEV_OFFLINE when ufs shutdown Seunghwan Baek
2024-08-29 9:39 ` [PATCH v1 1/1] ufs: core: set " Seunghwan Baek
2024-09-23 7:54 ` Seunghwan Baek
2024-09-23 17:31 ` Bart Van Assche
2024-09-23 17:41 ` Bart Van Assche
2024-09-24 2:17 ` Seunghwan Baek
2024-09-24 18:24 ` Bart Van Assche [this message]
2024-09-25 6:54 ` Seunghwan Baek
2024-10-08 5:27 ` Seunghwan Baek
2024-10-10 5:47 ` Kiwoong Kim
2024-10-08 17:58 ` Bart Van Assche
2024-10-16 2:39 ` [PATCH v1 0/1] Set " Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1845f326-e9eb-4351-9ed1-fce373c82cb0@acm.org \
--to=bvanassche@acm.org \
--cc=James.Bottomley@HansenPartnership.com \
--cc=alim.akhtar@samsung.com \
--cc=avri.altman@wdc.com \
--cc=cw9316.lee@samsung.com \
--cc=dh0421.hwang@samsung.com \
--cc=grant.jung@samsung.com \
--cc=jangsub.yi@samsung.com \
--cc=jt77.jang@samsung.com \
--cc=junwoo80.lee@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=sh043.lee@samsung.com \
--cc=sh8267.baek@samsung.com \
--cc=stable@vger.kernel.org \
--cc=wkon.kim@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox