From: Laurence Oberman <loberman@redhat.com>
To: Dave Jones <davej@codemonkey.org.uk>
Cc: linux-scsi@vger.kernel.org, Quinn Tran <quinn.tran@cavium.com>
Subject: Re: scsi: qla2xxx: Fix apparent cut-n-paste error.
Date: Wed, 28 Dec 2016 12:00:46 -0500 (EST) [thread overview]
Message-ID: <1874130276.10065793.1482944446039.JavaMail.zimbra@redhat.com> (raw)
In-Reply-To: <20161227181321.35xf5hm4qz3uajmp@codemonkey.org.uk>
----- Original Message -----
> From: "Dave Jones" <davej@codemonkey.org.uk>
> To: linux-scsi@vger.kernel.org
> Cc: "Quinn Tran" <quinn.tran@cavium.com>
> Sent: Tuesday, December 27, 2016 1:13:21 PM
> Subject: scsi: qla2xxx: Fix apparent cut-n-paste error.
>
> commit 093df73771bac8a37d607c0e705d157a8cef4c5c introduces two bodies of
> code that look similar but with s/req/rsp/ in the second instance.
> But in one case, it looks like this conversion was missed.
>
> Signed-off-by: Dave Jones <davej@codemonkey.org.uk>
>
> diff --git a/drivers/scsi/qla2xxx/qla_os.c b/drivers/scsi/qla2xxx/qla_os.c
> index 8521cfe302e9..ad4edc13ebcf 100644
> --- a/drivers/scsi/qla2xxx/qla_os.c
> +++ b/drivers/scsi/qla2xxx/qla_os.c
> @@ -466,7 +466,7 @@ static void qla2x00_free_queues(struct qla_hw_data *ha)
> continue;
>
> rsp = ha->rsp_q_map[cnt];
> - clear_bit(cnt, ha->req_qid_map);
> + clear_bit(cnt, ha->rsp_qid_map);
> ha->rsp_q_map[cnt] = NULL;
> spin_unlock_irqrestore(&ha->hardware_lock, flags);
> qla2x00_free_rsp_que(ha, rsp);
> --
> To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
Hi Dave
This had me going for a while but I figured out what you were pointing out.
Your change seems correct to me.
Reviewed-by: Laurence Oberman <loberman@redhat.com>
next prev parent reply other threads:[~2016-12-28 17:00 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-27 18:13 scsi: qla2xxx: Fix apparent cut-n-paste error Dave Jones
2016-12-28 17:00 ` Laurence Oberman [this message]
2017-01-06 1:52 ` Martin K. Petersen
2017-01-09 18:43 ` Tran, Quinn
2017-01-10 4:24 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1874130276.10065793.1482944446039.JavaMail.zimbra@redhat.com \
--to=loberman@redhat.com \
--cc=davej@codemonkey.org.uk \
--cc=linux-scsi@vger.kernel.org \
--cc=quinn.tran@cavium.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).