RE: [PATCH 01/11] scsi: ufs: Rename a function argument

[Keoseong Park <keosung.park@samsung.com>]

Hi Bart,

>The new name makes it clear what the meaning of the function argument is.
>
>Signed-off-by: Bart Van Assche <bvanassche@acm.org>

Reviewed-by: Keoseong Park <keosung.park@samsung.com>

Best Regards,
Keoseong Park

>---
> drivers/scsi/ufs/ufs-exynos.c | 4 ++--
> drivers/scsi/ufs/ufshcd.h     | 3 ++-
> 2 files changed, 4 insertions(+), 3 deletions(-)
>
>diff --git a/drivers/scsi/ufs/ufs-exynos.c b/drivers/scsi/ufs/ufs-exynos.c
>index cd26bc82462e..474a4a064a68 100644
>--- a/drivers/scsi/ufs/ufs-exynos.c
>+++ b/drivers/scsi/ufs/ufs-exynos.c
>@@ -853,14 +853,14 @@ static int exynos_ufs_post_pwr_mode(struct ufs_hba *hba,
> }
> 
> static void exynos_ufs_specify_nexus_t_xfer_req(struct ufs_hba *hba,
>-						int tag, bool op)
>+						int tag, bool is_scsi_cmd)
> {
> 	struct exynos_ufs *ufs = ufshcd_get_variant(hba);
> 	u32 type;
> 
> 	type =  hci_readl(ufs, HCI_UTRL_NEXUS_TYPE);
> 
>-	if (op)
>+	if (is_scsi_cmd)
> 		hci_writel(ufs, type | (1 << tag), HCI_UTRL_NEXUS_TYPE);
> 	else
> 		hci_writel(ufs, type & ~(1 << tag), HCI_UTRL_NEXUS_TYPE);
>diff --git a/drivers/scsi/ufs/ufshcd.h b/drivers/scsi/ufs/ufshcd.h
>index 4ceb3c7e65b4..a911ad72de7a 100644
>--- a/drivers/scsi/ufs/ufshcd.h
>+++ b/drivers/scsi/ufs/ufshcd.h
>@@ -338,7 +338,8 @@ struct ufs_hba_variant_ops {
> 					enum ufs_notify_change_status status,
> 					struct ufs_pa_layer_attr *,
> 					struct ufs_pa_layer_attr *);
>-	void	(*setup_xfer_req)(struct ufs_hba *, int, bool);
>+	void	(*setup_xfer_req)(struct ufs_hba *hba, int tag,
>+				  bool is_scsi_cmd);
> 	void	(*setup_task_mgmt)(struct ufs_hba *, int, u8);
> 	void    (*hibern8_notify)(struct ufs_hba *, enum uic_cmd_dme,
> 					enum ufs_notify_change_status);
>