RE: [PATCH 04/29] scsi: ufs: Remove ufshcd_lrb.sense_bufflen

[Keoseong Park <keosung.park@samsung.com>]

Hi Bart,
>ufshcd_lrb.sense_bufflen is set but never read. Hence remove this struct
>member.
> 
>Signed-off-by: Bart Van Assche <bvanassche@acm.org>

Reviewed-by: Keoseong Park <keosung.park@samsung.com>

Best Regards,
Keoseong Park

>---
> drivers/scsi/ufs/ufshcd.c | 3 ---
> drivers/scsi/ufs/ufshcd.h | 2 --
> 2 files changed, 5 deletions(-)
> 
>diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c
>index c60519372b3b..e52e86b0b7a3 100644
>--- a/drivers/scsi/ufs/ufshcd.c
>+++ b/drivers/scsi/ufs/ufshcd.c
>@@ -2789,7 +2789,6 @@ static int ufshcd_queuecommand(struct Scsi_Host *host, struct scsi_cmnd *cmd)
>         lrbp = &hba->lrb[tag];
>         WARN_ON(lrbp->cmd);
>         lrbp->cmd = cmd;
>-        lrbp->sense_bufflen = UFS_SENSE_SIZE;
>         lrbp->sense_buffer = cmd->sense_buffer;
>         lrbp->task_tag = tag;
>         lrbp->lun = ufshcd_scsi_to_upiu_lun(cmd->device->lun);
>@@ -2830,7 +2829,6 @@ static int ufshcd_compose_dev_cmd(struct ufs_hba *hba,
>                 struct ufshcd_lrb *lrbp, enum dev_cmd_type cmd_type, int tag)
> {
>         lrbp->cmd = NULL;
>-        lrbp->sense_bufflen = 0;
>         lrbp->sense_buffer = NULL;
>         lrbp->task_tag = tag;
>         lrbp->lun = 0; /* device management cmd is not specific to any LUN */
>@@ -6802,7 +6800,6 @@ static int ufshcd_issue_devman_upiu_cmd(struct ufs_hba *hba,
>         lrbp = &hba->lrb[tag];
>         WARN_ON(lrbp->cmd);
>         lrbp->cmd = NULL;
>-        lrbp->sense_bufflen = 0;
>         lrbp->sense_buffer = NULL;
>         lrbp->task_tag = tag;
>         lrbp->lun = 0;
>diff --git a/drivers/scsi/ufs/ufshcd.h b/drivers/scsi/ufs/ufshcd.h
>index b2740b51a546..b6162b208d99 100644
>--- a/drivers/scsi/ufs/ufshcd.h
>+++ b/drivers/scsi/ufs/ufshcd.h
>@@ -182,7 +182,6 @@ struct ufs_pm_lvl_states {
>  * @ucd_req_dma_addr: UPIU request dma address for debug
>  * @cmd: pointer to SCSI command
>  * @sense_buffer: pointer to sense buffer address of the SCSI command
>- * @sense_bufflen: Length of the sense buffer
>  * @scsi_status: SCSI status of the command
>  * @command_type: SCSI, UFS, Query.
>  * @task_tag: Task tag of the command
>@@ -207,7 +206,6 @@ struct ufshcd_lrb {
> 
>         struct scsi_cmnd *cmd;
>         u8 *sense_buffer;
>-        unsigned int sense_bufflen;
>         int scsi_status;
> 
>         int command_type;
>