From: Bart Van Assche <bvanassche@acm.org>
To: John Garry <john.g.garry@oracle.com>,
Juergen Gross <jgross@suse.com>,
"Martin K. Petersen" <martin.petersen@oracle.com>
Cc: linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org,
"James E.J. Bottomley" <jejb@linux.ibm.com>,
stable@vger.kernel.org
Subject: Re: [PATCH] scsi: Let scsi_execute_cmd() mark args->sshdr as invalid
Date: Mon, 22 May 2023 06:31:44 -0700 [thread overview]
Message-ID: <191c7661-c47f-5aba-97b9-ff698bda4bc7@acm.org> (raw)
In-Reply-To: <73e3da3d-ed90-6c38-3c8c-13653bd89944@oracle.com>
On 5/22/23 02:55, John Garry wrote:
> On 19/05/2023 18:39, Bart Van Assche wrote:
>> *args->resid = scmd->resid_len;
>> - if (args->sense)
>> - memcpy(args->sense, scmd->sense_buffer, SCSI_SENSE_BUFFERSIZE);
>> + if (args->sense) {
>> + *args->sense = scmd->sense_buffer;
>> + scmd->sense_buffer = NULL;
>
> I think that you will agree that this is not a good pattern to follow.
> We cannot have SCSI core allocating the sense buffer but a driver
> freeing it.
Why not? Something similar can happen anywhere in the kernel anywhere
reference counting is used.
Bart.
next prev parent reply other threads:[~2023-05-22 13:31 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-11 12:34 [PATCH] scsi: Let scsi_execute_cmd() mark args->sshdr as invalid Juergen Gross
2023-05-11 12:49 ` Bart Van Assche
2023-05-11 12:54 ` Juergen Gross
2023-05-11 13:10 ` Martin Wilck
2023-05-11 13:17 ` Juergen Gross
2023-05-11 13:23 ` Martin Wilck
2023-05-11 13:32 ` Juergen Gross
2023-05-11 15:59 ` Martin Wilck
2023-05-11 16:00 ` Martin Wilck
2023-05-17 2:06 ` Martin K. Petersen
2023-05-17 4:54 ` Juergen Gross
2023-05-17 15:05 ` John Garry
2023-05-18 4:53 ` Juergen Gross
2023-05-18 10:57 ` John Garry
2023-05-18 19:54 ` Bart Van Assche
2023-05-19 16:06 ` John Garry
2023-05-19 16:54 ` Bart Van Assche
2023-05-19 17:12 ` John Garry
2023-05-19 17:39 ` Bart Van Assche
2023-05-22 9:55 ` John Garry
2023-05-22 13:31 ` Bart Van Assche [this message]
2023-05-22 15:54 ` John Garry
2023-05-22 22:48 ` michael.christie
2023-05-21 1:19 ` Martin K. Petersen
2023-05-21 5:23 ` Juergen Gross
2023-05-22 22:26 ` Martin K. Petersen
2023-05-23 15:04 ` Mike Christie
2023-05-21 0:46 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=191c7661-c47f-5aba-97b9-ff698bda4bc7@acm.org \
--to=bvanassche@acm.org \
--cc=jejb@linux.ibm.com \
--cc=jgross@suse.com \
--cc=john.g.garry@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox