RE: [PATCH 1/5] megaraid_sas : Code optimization and refactoring

Sumit Saxena
2015-04-13T10:08:50Z

>-----Original Message-----
>From: Martin K. Petersen [mailto:martin.petersen@oracle.com]
>Sent: Wednesday, April 08, 2015 4:45 AM
>To: Sumit.Saxena@avagotech.com
>Cc: linux-scsi@vger.kernel.org; thenzl@redhat.com;
>martin.petersen@oracle.com; hch@infradead.org;
>jbottomley@parallels.com; kashyap.desai@avagotech.com
>Subject: Re: [PATCH 1/5] megaraid_sas : Code optimization and refactoring
>
>>>>>> "Sumit" == <Sumit.Saxena@avagotech.com> writes:
>
>Sumit> This patch has code optimization and refactoring in below areas-
>Sumit> 1) Created separate functions for sysPD IOs and non Read Write
>Sumit> LDIOs. 2) Added function for refiring MFI commands in controller
>Sumit> reset path. 3) Enabling interrupt immediately after adapter's
>Sumit> initialization. 4) Added function for setting up IRQs. 5)
>Sumit> Modified few prints for better logging. 6) Modified few macros
>Sumit> not to pass unused parameters. 7) Move internal commands and
>Sumit> SCSI commands reservation in adapter's sepcific functions.
>
>This needs to be 7 patches and not 1.
Ok, I will spilt this patch in 7 patches. Do you have any
feedback/comments for other patches of this series? IF you are ok with
other patches, I will resend the series with patch#1 splitted in 7 patches
and rest of the patches(2,3,4 and 5) will remain unchanged.
>
>--
>Martin K. Petersen Oracle Linux Engineering