Re: [PATCH 1/2] fusion : shost max_id not set in VMWare guest os

Re: [PATCH 1/2] fusion : shost max_id not set in VMWare guest os

[devzero]

Hi , 

there`s probably another bug in VMWare LSI emulated scsi controller, recent solaris builds crash the vmware process on boot (iirc, it was a regression introduced in snv_63).

from what i`ve read so far it happens during scsi device initialization from withing mpt driver, but unfortunately the mpt driver in solaris seems to be closed source.

since there i found no more information within vmware community or within opensolaris community about details of this bug - maybe anybody here knows what`s causing this crash and if it can perhaps be reproduced from within linux ?
i`m even unsure if some hacker could exploit this to break out of a virtual machine !? i`m running VMs in dmz setup.....

regards
roland



>[PATCH 1/2] fusion :  shost max_id not set in VMWare guest os
>
>In vmware guest os with emulated LSI 53c1030, the port facts config page is
>not having MaxDevices initialized to 16 devices. Instead its set to zero.
>Thereforewhen driver loads, no devices are scanned for from scsi_scan_host.
>Prior to the3.04.04 driver, shost max_id was set to hard coded value \
>MPT_MAX_SCSI_DEVICES. After that release, support for greater than 255 targets was \
>added, and the driver was taking the target count from the port facts instead.  With \
>this patch we will restore the hard coded values for SPI, but at the same time use \
>the settingsneeded for SAS and Fibre Channel.
>
>Signed-off-by: Eric Moore <Eric.Moore@lsi.com>

__________________________________________________________________________
Erweitern Sie FreeMail zu einem noch leistungsstärkeren E-Mail-Postfach!		
Mehr Infos unter http://produkte.web.de/club/?mc=021131

-
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH 1/2] fusion : shost max_id not set in VMWare guest os

[Eric Moore]

[PATCH 1/2] fusion :  shost max_id not set in VMWare guest os

In vmware guest os with emulated LSI 53c1030, the port facts config page is
not having MaxDevices initialized to 16 devices. Instead its set to zero.
Thereforewhen driver loads, no devices are scanned for from scsi_scan_host.
Prior to the3.04.04 driver, shost max_id was set to hard coded value MPT_MAX_SCSI_DEVICES. After that release, support for greater than 255 targets was added, and the driver was taking the target count from the port facts instead.  With this patch we will restore the hard coded values for SPI, but at the same time use the settingsneeded for SAS and Fibre Channel.

Signed-off-by: Eric Moore <Eric.Moore@lsi.com>


diff -uarpN b/drivers/message/fusion/mptbase.c a/drivers/message/fusion/mptbase.c
--- b/drivers/message/fusion/mptbase.c	2007-03-15 18:20:01.000000000 -0600
+++ a/drivers/message/fusion/mptbase.c	2007-03-18 12:05:54.000000000 -0600
@@ -2570,8 +2570,19 @@ GetPortFacts(MPT_ADAPTER *ioc, int portn
 	pfacts->MaxPersistentIDs = le16_to_cpu(pfacts->MaxPersistentIDs);
 	pfacts->MaxLanBuckets = le16_to_cpu(pfacts->MaxLanBuckets);
 
-	max_id = (ioc->bus_type == SAS) ? pfacts->PortSCSIID :
-	    pfacts->MaxDevices;
+	switch (ioc->bus_type) {
+	case SAS:
+		max_id = pfacts->PortSCSIID;
+		break;
+	case FC:
+		max_id = pfacts->MaxDevices;
+		break;
+	case SPI:
+	default:
+		max_id = MPT_MAX_SCSI_DEVICES;
+		break;
+	}
+
 	ioc->devices_per_bus = (max_id > 255) ? 256 : max_id;
 	ioc->number_of_buses = (ioc->devices_per_bus < 256) ? 1 : max_id/256;
 

Re: [PATCH 1/2] fusion : shost max_id not set in VMWare guest os

[Christoph Hellwig]

On Mon, Mar 19, 2007 at 10:30:43AM -0600, Eric Moore wrote:
> [PATCH 1/2] fusion :  shost max_id not set in VMWare guest os
> 
> In vmware guest os with emulated LSI 53c1030, the port facts config page is
> not having MaxDevices initialized to 16 devices. Instead its set to zero.
> Thereforewhen driver loads, no devices are scanned for from scsi_scan_host.
> Prior to the3.04.04 driver, shost max_id was set to hard coded value MPT_MAX_SCSI_DEVICES. After that release, support for greater than 255 targets was added, and the driver was taking the target count from the port facts instead.  With this patch we will restore the hard coded values for SPI, but at the same time use the settingsneeded for SAS and Fibre Channel.

NACK, just get Vmware folks to fix their broken emulation.