From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from 013.lax.mailroute.net (013.lax.mailroute.net [199.89.1.16]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AE091374E62 for ; Mon, 20 Apr 2026 16:46:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=199.89.1.16 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776703565; cv=none; b=BuDAdCMQmXFbopO/KGObc3tY5h0xxyz8Arp3U8iq4aM6AvkNXqv5gBsvLN+gCOIMGCPkdGmpKVSPg4fmZ8Xgdm/zXsD0u6jSYzmWKBsn3wPEQhoJ3qP7SDrjWLt7e0z7+CKYk1UWgozTx68pvu+/CaCu77olsqE+LenIb4+Sj9E= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776703565; c=relaxed/simple; bh=a1XvIzRqF9Um1gWWHn1rOVng4I/mmpgPQ4X6IBbrF4Y=; h=Message-ID:Date:MIME-Version:Subject:To:References:From: In-Reply-To:Content-Type; b=PsdE5XdriuoOYiElgrk1335Ej1/ZRAKh6p80GP4/lyZYZcF0ZvGpTEWlFpiUVrNGBmq3/lqEUuT2/hH4GKh6qwapMmRRjLgviAlMyTWMToD16FGatUOyGmEkCPY1Jez5gjL67o9+idztchn/NSnXYYJcMOuRuoFUwVBLcly5DtE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=acm.org; spf=pass smtp.mailfrom=acm.org; dkim=pass (2048-bit key) header.d=acm.org header.i=@acm.org header.b=TRsRi8HK; arc=none smtp.client-ip=199.89.1.16 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=acm.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=acm.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=acm.org header.i=@acm.org header.b="TRsRi8HK" Received: from localhost (localhost [127.0.0.1]) by 013.lax.mailroute.net (Postfix) with ESMTP id 4fzrwB327lzlfdGT; Mon, 20 Apr 2026 16:46:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=acm.org; h= content-transfer-encoding:content-type:content-type:in-reply-to :from:from:content-language:references:subject:subject :user-agent:mime-version:date:date:message-id:received:received; s=mr01; t=1776703557; x=1779295558; bh=pTx7u0MM1e2vMoE0exJ4KVsC SAcmcTRz2iIaFUsZGj0=; b=TRsRi8HKCStclphfeuEYPBDwNVVsFsUiWr3dTDQG jfjufXFyTxs6iOpr/8bvZ7a8r/o0+1FqaYBqceyU82aixqpEivXS/XL9OELCUoSB Vref3COi5dYOjhY54f0jYjwiSADmoJrSoKYolAbD4BR5TYlr27tKwlUZrjxvo+0w 4f3Ryf+A5Mca0ImfJQxb+CcNyufYDoxfTnanpCH7R41u1nmuamcdGKkHwk/grKvA 1LFjt8LX3AKXZw2tPQONl00xwBCh454D8xj6RF+uvj6WUnZNIbzAnRejdHGTQVqW ekS9dT8R2FuJfd1aRBzOqEiVOTWIfRtXLed0JOQum79RWg== X-Virus-Scanned: by MailRoute Received: from 013.lax.mailroute.net ([127.0.0.1]) by localhost (013.lax [127.0.0.1]) (mroute_mailscanner, port 10029) with LMTP id uIbwegIsavq0; Mon, 20 Apr 2026 16:45:57 +0000 (UTC) Received: from [100.119.48.131] (unknown [104.135.180.219]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: bvanassche@acm.org) by 013.lax.mailroute.net (Postfix) with ESMTPSA id 4fzrw311PZzlfddf; Mon, 20 Apr 2026 16:45:54 +0000 (UTC) Message-ID: <197fd58e-2cc7-4ed8-a662-52120f39c5e2@acm.org> Date: Mon, 20 Apr 2026 09:45:54 -0700 Precedence: bulk X-Mailing-List: linux-scsi@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/4] scsi: qedi: Fix command overqueueing To: Mike Christie , martin.petersen@oracle.com, linux-scsi@vger.kernel.org, james.bottomley@hansenpartnership.com, virtualization@lists.linux.dev, mst@redhat.com, pbonzini@redhat.com, stefanha@redhat.com, eperezma@redhat.com References: <20260417230751.117836-1-michael.christie@oracle.com> <20260417230751.117836-3-michael.christie@oracle.com> Content-Language: en-US From: Bart Van Assche In-Reply-To: <20260417230751.117836-3-michael.christie@oracle.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 4/17/26 3:57 PM, Mike Christie wrote: > qedi supports a total of can_queue commands over all queues so set > host_tagset when multiple queues are used. > > Signed-off-by: Mike Christie > --- > drivers/scsi/qedi/qedi_main.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/scsi/qedi/qedi_main.c b/drivers/scsi/qedi/qedi_main.c > index 227ff7bd1bdc..0be0a9f30ee2 100644 > --- a/drivers/scsi/qedi/qedi_main.c > +++ b/drivers/scsi/qedi/qedi_main.c > @@ -657,6 +657,8 @@ static struct qedi_ctx *qedi_host_alloc(struct pci_dev *pdev) > qedi->max_sqes = QEDI_SQ_SIZE; > > shost->nr_hw_queues = MIN_NUM_CPUS_MSIX(qedi); > + if (shost->nr_hw_queues > 1) > + shost->host_tagset = 1; > > pci_set_drvdata(pdev, qedi); > Why "if (shost->nr_hw_queues > 1)"? It is safe to set host_tagset even if shost->nr_hw_queues == 1. See e.g. "[PATCH] ufs: core: Use a host- wide tagset in SDB mode" (https://lore.kernel.org/linux-scsi/20260116180800.3085233-1-bvanassche@acm.org/). Thanks, Bart.