[PATCH 2/5] arcmsr: Support Hibernation

["NickCheng" <nick.cheng@areca.com.tw>]

[-- Attachment #1: Type: text/plain, Size: 157 bytes --]

From: Nick Cheng <nick.cheng@areca.com.tw>

Support hibernation for whole series of RAID controllers
Signed-off-by: Nick Cheng <nick.cheng@areca.com.tw>
---

[-- Attachment #2: checkpatch2 --]
[-- Type: application/octet-stream, Size: 2202 bytes --]

WARNING: Too many leading tabs - consider code refactoring
#70: FILE: drivers/scsi/arcmsr/arcmsr_hba.c:567:
+							if (psdev != NULL) {

WARNING: line over 80 characters
#71: FILE: drivers/scsi/arcmsr/arcmsr_hba.c:568:
+								scsi_remove_device(psdev);

WARNING: line over 80 characters
#72: FILE: drivers/scsi/arcmsr/arcmsr_hba.c:569:
+								scsi_device_put(psdev);

WARNING: braces {} are not necessary for single statement blocks
#96: FILE: drivers/scsi/arcmsr/arcmsr_hba.c:692:
+			for (i = 0; i < ARCMST_NUM_MSIX_VECTORS; i++) {
+				free_irq(acb->entries[i].vector, acb);
+			}

WARNING: printk() should include KERN_ facility level
#127: FILE: drivers/scsi/arcmsr/arcmsr_hba.c:723:
+			printk("%s: pci_enable_device error\n", __func__);

WARNING: Too many leading tabs - consider code refactoring
#150: FILE: drivers/scsi/arcmsr/arcmsr_hba.c:746:
+						for (j = 0 ; j < i ; j++)

WARNING: line over 80 characters
#151: FILE: drivers/scsi/arcmsr/arcmsr_hba.c:747:
+							free_irq(entries[i].vector,

WARNING: printk() should include KERN_ facility level
#159: FILE: drivers/scsi/arcmsr/arcmsr_hba.c:755:
+				printk("arcmsr%d: MSI-X"

WARNING: quoted string split across lines
#160: FILE: drivers/scsi/arcmsr/arcmsr_hba.c:756:
+				printk("arcmsr%d: MSI-X"
+				"failed to enable\n", acb->host->host_no);

WARNING: braces {} are not necessary for single statement blocks
#168: FILE: drivers/scsi/arcmsr/arcmsr_hba.c:764:
+			if (!pci_enable_msi(pdev)) {
+				acb->acb_flags |= ACB_F_MSI_ENABLED;
+			}

WARNING: quoted string split across lines
#231: FILE: drivers/scsi/arcmsr/arcmsr_hba.c:1100:
 			pr_notice("arcmsr%d: scsi id = %d lun = %d"
+				"isr get command error done, but got unknown"

WARNING: quoted string split across lines
#263: FILE: drivers/scsi/arcmsr/arcmsr_hba.c:2403:
 		pr_notice("arcmsr%d: wait 'get adapter firmware"
+			"miscellaneous data' timeout\n",

ERROR: Missing Signed-off-by: line(s)

total: 1 errors, 12 warnings, 259 lines checked

../patch2 has style problems, please review.

If any of these errors are false positives, please report
them to the maintainer, see CHECKPATCH in MAINTAINERS.