From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9824AC433EF for ; Thu, 3 Mar 2022 16:32:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235071AbiCCQcp (ORCPT ); Thu, 3 Mar 2022 11:32:45 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43876 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235070AbiCCQcn (ORCPT ); Thu, 3 Mar 2022 11:32:43 -0500 Received: from esa4.hgst.iphmx.com (esa4.hgst.iphmx.com [216.71.154.42]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B740D19D62E for ; Thu, 3 Mar 2022 08:31:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=wdc.com; i=@wdc.com; q=dns/txt; s=dkim.wdc.com; t=1646325115; x=1677861115; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=CQ8T9/Kbhd6Yy81cQxXm9sARrwJUyfmP5Zwrr+TZSKE=; b=ARbn4HUhFDgTPEFHSNHXWU6vOw1G1wjYej8fdj0vAzYwhqazHxuO11Ih VR8ftEKv3P3w3B7TpXnDJhA9/sbqQzS9JLPWH0hh2CldUk9zcxPTLPjxx HZhINi/M8DAAD+SikptwX6uFpEQVmtV0BrNwfKPmah3rpzz74CYDz6bXG RL6mz/PKrYqapQS22S1bwv0UA6/U/o9rd/vYfy2ndKkHCesihxzZGtjWf 9JUweeC+qhWfLkckSwWR4yk0Q77gFTiMl0pPdywTiWZdkQ/y6atVPmKCP d97Phk/M+sVm1kTDba+g1GtYM9FvE5cW37L5Lt7VVK09Q1yOxTE4BUCKE w==; X-IronPort-AV: E=Sophos;i="5.90,151,1643644800"; d="scan'208";a="193333353" Received: from h199-255-45-14.hgst.com (HELO uls-op-cesaep01.wdc.com) ([199.255.45.14]) by ob1.hgst.iphmx.com with ESMTP; 04 Mar 2022 00:31:53 +0800 IronPort-SDR: BmpoCHgkuNzzgFmrmQKeOKJ8ojnxUoa57zqp57rIY+9k0XoXBSEn+3RmoAJ7lEtjTsF2tJX3Yj 5gcJig9YPBnFhSw4YAy+6Cg8jdt7sBFmL6Wq3Wzcstfc2qFoKd4w8Rn6LGQnwjw1q5l0xmr8jt W9lF/1jWZ46zKyUXMRwN9DkU788Z7SqwCEnLwjxO4LMpeKdf7YoIztUo3JoSPSKRbGuWvwebd1 ThfIwpCfHyzIQDPMH7hdWSQDGtt3u+malQBpyDhITK6Ha2GjbtWA3JDTedjmMFACmIAWvINSkA d0TJCyz0ptGhZ7U4etERL48z Received: from uls-op-cesaip02.wdc.com ([10.248.3.37]) by uls-op-cesaep01.wdc.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Mar 2022 08:04:17 -0800 IronPort-SDR: XxxiZiBacHJlvNfc10pwAOJqtbTwjkSEinz5ArCHZ/uSEl6ZtZUVTKNGTckDqht8obXnV6MEGp M4385InfNzawMch3p0U/diI0aso1p9t8cc2ECmtebx1ywQr8bLoWuodMRw8ZrmY8udnKyVnyUT mBlxMnTCjgoX+rNdyfuWWTMg2a5I4jm8X7jmF9D1c5G2odXW4dX61ojzUeQ/54uDn9wNpjyhPy vqhyAarPDEl9wnOVjLRyB6t0sEZeBWIPVWayZJwGluxy8X08vRiwdjdFNlXmQhJU4WvqFbHezf Ucs= WDCIronportException: Internal Received: from usg-ed-osssrv.wdc.com ([10.3.10.180]) by uls-op-cesaip02.wdc.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Mar 2022 08:31:54 -0800 Received: from usg-ed-osssrv.wdc.com (usg-ed-osssrv.wdc.com [127.0.0.1]) by usg-ed-osssrv.wdc.com (Postfix) with ESMTP id 4K8c2K0KbFz1SVp1 for ; Thu, 3 Mar 2022 08:31:52 -0800 (PST) Authentication-Results: usg-ed-osssrv.wdc.com (amavisd-new); dkim=pass reason="pass (just generated, assumed good)" header.d=opensource.wdc.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d= opensource.wdc.com; h=content-transfer-encoding:content-type :in-reply-to:organization:from:references:to:content-language :subject:user-agent:mime-version:date:message-id; s=dkim; t= 1646325111; x=1648917112; bh=CQ8T9/Kbhd6Yy81cQxXm9sARrwJUyfmP5Zw rr+TZSKE=; b=l3hHKVgz5D8FsKrZpqSitVBd+ur1Sq8+wQR9zoPwtyeoTK6cpwJ aDvDMuG4D9jllrkR6uyUU22W9KGju/DNnqKlTjH/KuZeir8fxOi+UpPbutZXHSOz O8nCcEK6++naX7iDyzE7/PwvbNEKAc0VS4DaorAkHOLeOhD39jdSrIc3B4ECV94x 2M8tPIkW6fj4iMXA/KAckXL78j9tT5RK/B2E5RLfmHBwcNboYEW2L9gd1dGZTnJ2 XSrsxN+5E7p60RwXaFS8bQJ8Fj/aq2zuN+JtJL7OUAz9zroQgf9FXLs2RyAB7ud1 q1K+gMPoaH8cbRWQSO8ceqbKfYrNUHAlrSg== X-Virus-Scanned: amavisd-new at usg-ed-osssrv.wdc.com Received: from usg-ed-osssrv.wdc.com ([127.0.0.1]) by usg-ed-osssrv.wdc.com (usg-ed-osssrv.wdc.com [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id G5v-d9DWOclM for ; Thu, 3 Mar 2022 08:31:51 -0800 (PST) Received: from [10.225.33.67] (unknown [10.225.33.67]) by usg-ed-osssrv.wdc.com (Postfix) with ESMTPSA id 4K8c2C728yz1Rvlx; Thu, 3 Mar 2022 08:31:47 -0800 (PST) Message-ID: <1a868ac0-e5bb-7efb-c1f8-eda0b040f5db@opensource.wdc.com> Date: Thu, 3 Mar 2022 18:31:45 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.6.1 Subject: Re: [PATCH 1/4] scsi: libsas: Add sas_execute_internal_abort_single() Content-Language: en-US To: John Garry , jejb@linux.ibm.com, martin.petersen@oracle.com, jinpu.wang@cloud.ionos.com Cc: linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org, Ajish.Koshy@microchip.com, linuxarm@huawei.com, Viswas.G@microchip.com, hch@lst.de, liuqi115@huawei.com, chenxiang66@hisilicon.com References: <1646309930-138960-1-git-send-email-john.garry@huawei.com> <1646309930-138960-2-git-send-email-john.garry@huawei.com> From: Damien Le Moal Organization: Western Digital Research In-Reply-To: <1646309930-138960-2-git-send-email-john.garry@huawei.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org On 2022/03/03 14:18, John Garry wrote: > The internal abort feature is common to hisi_sas and pm8001 HBAs, and the > driver support is similar also, so add a common handler. > > Two modes of operation will be supported: > - single: Abort a single tagged command > - device: Abort all commands associated with a specific domain device > > A new protocol is added, SAS_PROTOCOL_INTERNAL_ABORT, so the common queue > command API may be re-used. > > Only add "single" support as a first step. > > Signed-off-by: John Garry > --- > drivers/scsi/libsas/sas_scsi_host.c | 75 +++++++++++++++++++++++++++++ > include/scsi/libsas.h | 14 ++++++ > include/scsi/sas.h | 2 + > 3 files changed, 91 insertions(+) > > diff --git a/drivers/scsi/libsas/sas_scsi_host.c b/drivers/scsi/libsas/sas_scsi_host.c > index 5b5747e33dbd..0d05826e6e8c 100644 > --- a/drivers/scsi/libsas/sas_scsi_host.c > +++ b/drivers/scsi/libsas/sas_scsi_host.c > @@ -920,6 +920,81 @@ void sas_task_internal_timedout(struct timer_list *t) > #define TASK_TIMEOUT (20 * HZ) > #define TASK_RETRY 3 > > +static int sas_execute_internal_abort(struct domain_device *device, > + enum sas_internal_abort type, u16 tag, > + unsigned int qid, void *data) > +{ > + struct sas_ha_struct *ha = device->port->ha; > + struct sas_internal *i = to_sas_internal(ha->core.shost->transportt); > + struct sas_task *task = NULL; > + int res, retry; > + > + for (retry = 0; retry < TASK_RETRY; retry++) { > + task = sas_alloc_slow_task(GFP_KERNEL); > + if (!task) > + return -ENOMEM; > + > + task->dev = device; > + task->task_proto = SAS_PROTOCOL_INTERNAL_ABORT; > + task->task_done = sas_task_internal_done; > + task->slow_task->timer.function = sas_task_internal_timedout; > + task->slow_task->timer.expires = jiffies + TASK_TIMEOUT; > + add_timer(&task->slow_task->timer); > + > + task->abort_task.tag = tag; > + task->abort_task.type = type; > + > + res = i->dft->lldd_execute_task(task, GFP_KERNEL); > + if (res) { > + del_timer_sync(&task->slow_task->timer); > + pr_err("Executing internal abort failed %016llx (%d)\n", > + SAS_ADDR(device->sas_addr), res); > + break; > + } > + > + wait_for_completion(&task->slow_task->completion); > + res = TMF_RESP_FUNC_FAILED; > + > + /* Even if the internal abort timed out, return direct. */ > + if (task->task_state_flags & SAS_TASK_STATE_ABORTED) { > + pr_err("Internal abort: timeout %016llx\n", > + SAS_ADDR(device->sas_addr)); > + Nit: blank line not needed here ? > + res = -EIO; > + break; > + } > + > + if (task->task_status.resp == SAS_TASK_COMPLETE && > + task->task_status.stat == SAS_SAM_STAT_GOOD) { > + res = TMF_RESP_FUNC_COMPLETE; > + break; > + } > + > + if (task->task_status.resp == SAS_TASK_COMPLETE && > + task->task_status.stat == TMF_RESP_FUNC_SUCC) { > + res = TMF_RESP_FUNC_SUCC; > + break; > + } > + > + pr_err("Internal abort: task to dev %016llx response: 0x%x status 0x%x\n", > + SAS_ADDR(device->sas_addr), task->task_status.resp, > + task->task_status.stat); > + sas_free_task(task); > + task = NULL; > + } > + BUG_ON(retry == TASK_RETRY && task != NULL); > + sas_free_task(task); > + return res; > +} > + > +int sas_execute_internal_abort_single(struct domain_device *device, u16 tag, > + unsigned int qid, void *data) > +{ > + return sas_execute_internal_abort(device, SAS_INTERNAL_ABORT_SINGLE, > + tag, qid, data); > +} > +EXPORT_SYMBOL_GPL(sas_execute_internal_abort_single); > + > int sas_execute_tmf(struct domain_device *device, void *parameter, > int para_len, int force_phy_id, > struct sas_tmf_task *tmf) > diff --git a/include/scsi/libsas.h b/include/scsi/libsas.h > index df2c8fc43429..2d30d57916e5 100644 > --- a/include/scsi/libsas.h > +++ b/include/scsi/libsas.h > @@ -557,6 +557,16 @@ struct sas_ata_task { > int force_phy_id; > }; > > +/* LLDDs rely on these values */ > +enum sas_internal_abort { > + SAS_INTERNAL_ABORT_SINGLE = 0, > +}; > + > +struct sas_internal_abort_task { > + enum sas_internal_abort type; > + u16 tag; > +}; > + > struct sas_smp_task { > struct scatterlist smp_req; > struct scatterlist smp_resp; > @@ -596,6 +606,7 @@ struct sas_task { > struct sas_ata_task ata_task; > struct sas_smp_task smp_task; > struct sas_ssp_task ssp_task; > + struct sas_internal_abort_task abort_task; > }; > > struct scatterlist *scatter; > @@ -683,6 +694,9 @@ extern int sas_slave_configure(struct scsi_device *); > extern int sas_change_queue_depth(struct scsi_device *, int new_depth); > extern int sas_bios_param(struct scsi_device *, struct block_device *, > sector_t capacity, int *hsc); > +int sas_execute_internal_abort_single(struct domain_device *device, > + u16 tag, unsigned int qid, > + void *data); > extern struct scsi_transport_template * > sas_domain_attach_transport(struct sas_domain_function_template *); > extern struct device_attribute dev_attr_phy_event_threshold; > diff --git a/include/scsi/sas.h b/include/scsi/sas.h > index 332a463d08ef..acfc69fd72d0 100644 > --- a/include/scsi/sas.h > +++ b/include/scsi/sas.h > @@ -95,6 +95,8 @@ enum sas_protocol { > SAS_PROTOCOL_SSP = 0x08, > SAS_PROTOCOL_ALL = 0x0E, > SAS_PROTOCOL_STP_ALL = SAS_PROTOCOL_STP|SAS_PROTOCOL_SATA, > + /* these are internal to libsas */ > + SAS_PROTOCOL_INTERNAL_ABORT = 0x10, > }; > > /* From the spec; local phys only */ -- Damien Le Moal Western Digital Research