From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id ED70BC433F5 for ; Wed, 16 Mar 2022 08:15:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1354435AbiCPIRA (ORCPT ); Wed, 16 Mar 2022 04:17:00 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57120 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S245093AbiCPIQ7 (ORCPT ); Wed, 16 Mar 2022 04:16:59 -0400 Received: from frasgout.his.huawei.com (frasgout.his.huawei.com [185.176.79.56]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C1A9263502; Wed, 16 Mar 2022 01:15:45 -0700 (PDT) Received: from fraeml709-chm.china.huawei.com (unknown [172.18.147.207]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4KJNMg5S0wz67Zgf; Wed, 16 Mar 2022 16:13:51 +0800 (CST) Received: from lhreml724-chm.china.huawei.com (10.201.108.75) by fraeml709-chm.china.huawei.com (10.206.15.37) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Wed, 16 Mar 2022 09:15:43 +0100 Received: from [10.47.84.96] (10.47.84.96) by lhreml724-chm.china.huawei.com (10.201.108.75) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.21; Wed, 16 Mar 2022 08:15:42 +0000 Message-ID: <1bde0883-bfbb-ea54-82f0-4e53b884b24b@huawei.com> Date: Wed, 16 Mar 2022 08:15:41 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.6.1 Subject: Re: [PATCH 0/2] scsi/libata: A potential tagging fix and improvement To: Damien Le Moal , , , , , , CC: , , , References: <1647340746-17600-1-git-send-email-john.garry@huawei.com> From: John Garry In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.47.84.96] X-ClientProxiedBy: lhreml735-chm.china.huawei.com (10.201.108.86) To lhreml724-chm.china.huawei.com (10.201.108.75) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org On 16/03/2022 03:25, Damien Le Moal wrote:s Hi Damien, > I tested this and it is working fine for me. This actually solves the QD > not changing problem I had detected with the pm80xx driver. > Now, doing this: > > # cat /sys/block/sde/device/queue_depth > 32 > # echo 16 > /sys/block/sde/device/queue_depth > # cat /sys/block/sde/device/queue_depth > 16 > Having this working is down to the first patch. So I will resend that patch today separately so that we may look to have it included in 5.18, even though we're so late in the cycle... > is working as expected. > > See my comments on patch 2 for getting final ack and tested tags:) OK, Thanks, John