From: John Garry <john.g.garry@oracle.com>
To: "Martin K. Petersen" <martin.petersen@oracle.com>,
Chris Bainbridge <chris.bainbridge@gmail.com>
Cc: fengli@smartx.com, hch@lst.de, axboe@kernel.dk,
linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [REGRESSION] critical target error, bisected
Date: Fri, 16 Aug 2024 09:21:50 +0100 [thread overview]
Message-ID: <1c03c6bb-b05b-4052-8a75-c062ce3af28e@oracle.com> (raw)
In-Reply-To: <yq1ikw1qg49.fsf@ca-mkp.ca.oracle.com>
On 16/08/2024 04:56, Martin K. Petersen wrote:
>
> Chris,
>
>> [ 195.647081] sd 0:0:0:0: [sda] tag#0 FAILED Result: hostbyte=DID_OK driverbyte=DRIVER_OK cmd_age=0s
>> [ 195.647093] sd 0:0:0:0: [sda] tag#0 Sense Key : Illegal Request [current]
>> [ 195.647096] sd 0:0:0:0: [sda] tag#0 Add. Sense: Invalid command operation code
>> [ 195.647099] sd 0:0:0:0: [sda] tag#0 CDB: Write same(16) 93 08 00 00 00 00 04 dd 42 f8 00 00 2d 48 00 00
>> [ 195.647101] critical target error, dev sda, sector 81609464 op 0x3:(DISCARD) flags 0x800 phys_seg 1 prio class 0
>
> I would appreciate if you could test the following patch.
>
> Thanks!
>
That solves the issue I was seeing on default scsi_debug, like this:
# mkfs.xfs -V
mkfs.xfs version 5.14.2
# mkfs.xfs /dev/sda
meta-data=/dev/sda isize=512 agcount=4, agsize=22400 blks
= sectsz=512 attr=2, projid32bit=1
= crc=1 finobt=1, sparse=1, rmapbt=0
= reflink=1 bigtime=0 inobtcount=0
data = bsize=4096 blocks=89600, imaxpct=25
= sunit=0 swidth=0 blks
naming =version 2 bsize=4096 ascii-ci=0, ftype=1
log =internal log bsize=4096 blocks=1368, version=2
= sectsz=512 sunit=0 blks, lazy-count=1
realtime =none extsz=4096 blocks=0, rtextents=0
[ 29.399767] sd 0:0:0:0: [sda] tag#166 FAILED Result:
hostbyte=DID_OK driverbyte=DRIVER_OK cmd_age=0s
[ 29.401463] sd 0:0:0:0: [sda] tag#166 Sense Key : Illegal Request
[current]
[ 29.403072] sd 0:0:0:0: [sda] tag#166 Add. Sense: Invalid field in cdb
[ 29.404076] sd 0:0:0:0: [sda] tag#166 CDB: Write same(16) 93 08 00
00 00 00 00 00 00 00 00 00 ff ff 00 00
[ 29.405344] critical target error, dev sda, sector 0 op
0x3:(DISCARD) flags 0x4800 phys_seg 1 prio class 0
[ 29.408127] sd 0:0:0:0: [sda] tag#167 FAILED Result:
hostbyte=DID_OK driverbyte=DRIVER_OK cmd_age=0s
[ 29.410054] sd 0:0:0:0: [sda] tag#167 Sense Key : Illegal Request
[current]
[ 29.413442] sd 0:0:0:0: [sda] tag#167 Add. Sense: Invalid field in cdb
[ 29.414552] sd 0:0:0:0: [sda] tag#167 CDB: Write same(16) 93 08 00
00 00 00 00 00 ff ff 00 00 ff ff 00 00
[ 29.416241] critical target error, dev sda, sector 65535 op
0x3:(DISCARD) flags 0x4800 phys_seg 1 prio class 0
[ 29.418022] sd 0:0:0:0: [sda] tag#168 FAILED Result:
hostbyte=DID_OK driverbyte=DRIVER_OK cmd_age=0s
[ 29.419604] sd 0:0:0:0: [sda] tag#168 Sense Key : Illegal Request
[current]
[ 29.420826] sd 0:0:0:0: [sda] tag#168 Add. Sense: Invalid field in cdb
[ 29.421978] sd 0:0:0:0: [sda] tag#168 CDB: Write same(16) 93 08 00
00 00 00 00 01 ff fe 00 00 ff ff 00 00
[ 29.423591] critical target error, dev sda, sector 131070 op
0x3:(DISCARD) flags 0x4800 phys_seg 1 prio class 0
[ 29.425301] sd 0:0:0:0: [sda] tag#169 FAILED Result:
hostbyte=DID_OK driverbyte=DRIVER_OK cmd_age=0s
[ 29.426856] sd 0:0:0:0: [sda] tag#169 Sense Key : Illegal Request
[current]
[ 29.428020] sd 0:0:0:0: [sda] tag#169 Add. Sense: Invalid field in cdb
[ 29.429329] sd 0:0:0:0: [sda] tag#169 CDB: Write same(16) 93 08 00
00 00 00 00 02 ff fd 00 00 ff ff 00 00
[ 29.431314] critical target error, dev sda, sector 196605 op
0x3:(DISCARD) flags 0x4800 phys_seg 1 prio class 0
[ 29.433681] sd 0:0:0:0: [sda] tag#170 FAILED Result:
hostbyte=DID_OK driverbyte=DRIVER_OK cmd_age=0s
[ 29.435182] sd 0:0:0:0: [sda] tag#170 Sense Key : Illegal Request
[current]
[ 29.436328] sd 0:0:0:0: [sda] tag#170 Add. Sense: Invalid field in cdb
[ 29.437372] sd 0:0:0:0: [sda] tag#170 CDB: Write same(16) 93 08 00
00 00 00 00 03 ff fc 00 00 ff ff 00 00
[ 29.438895] critical target error, dev sda, sector 262140 op
0x3:(DISCARD) flags 0x4800 phys_seg 1 prio class 0
[ 29.440572] sd 0:0:0:0: [sda] tag#171 FAILED Result:
hostbyte=DID_OK driverbyte=DRIVER_OK cmd_age=0s
[ 29.442080] sd 0:0:0:0: [sda] tag#171 Sense Key : Illegal Request
[current]
[ 29.443277] sd 0:0:0:0: [sda] tag#171 Add. Sense: Invalid field in cdb
[ 29.444353] sd 0:0:0:0: [sda] tag#171 CDB: Write same(16) 93 08 00
00 00 00 00 04 ff fb 00 00 ff ff 00 00
[ 29.445919] critical target error, dev sda, sector 327675 op
0x3:(DISCARD) flags 0x4800 phys_seg 1 prio class 0
[ 29.447607] sd 0:0:0:0: [sda] tag#172 FAILED Result:
hostbyte=DID_OK driverbyte=DRIVER_OK cmd_age=0s
[ 29.449145] sd 0:0:0:0: [sda] tag#172 Sense Key : Illegal Request
[current]
[ 29.450327] sd 0:0:0:0: [sda] tag#172 Add. Sense: Invalid field in cdb
[ 29.451447] sd 0:0:0:0: [sda] tag#172 CDB: Write same(16) 93 08 00
00 00 00 00 05 ff fa 00 00 ff ff 00 00
[ 29.452995] critical target error, dev sda, sector 393210 op
0x3:(DISCARD) flags 0x4800 phys_seg 1 prio class 0
[ 29.454712] sd 0:0:0:0: [sda] tag#173 FAILED Result:
hostbyte=DID_OK driverbyte=DRIVER_OK cmd_age=0s
[ 29.456199] sd 0:0:0:0: [sda] tag#173 Sense Key : Illegal Request
[current]
[ 29.457409] sd 0:0:0:0: [sda] tag#173 Add. Sense: Invalid field in cdb
[ 29.458486] sd 0:0:0:0: [sda] tag#173 CDB: Write same(16) 93 08 00
00 00 00 00 06 ff f9 00 00 ff ff 00 00
[ 29.459836] critical target error, dev sda, sector 458745 op
0x3:(DISCARD) flags 0x4800 phys_seg 1 prio class 0
[ 29.461266] sd 0:0:0:0: [sda] tag#174 FAILED Result:
hostbyte=DID_OK driverbyte=DRIVER_OK cmd_age=0s
[ 29.462608] sd 0:0:0:0: [sda] tag#174 Sense Key : Illegal Request
[current]
[ 29.463791] sd 0:0:0:0: [sda] tag#174 Add. Sense: Invalid field in cdb
[ 29.464854] sd 0:0:0:0: [sda] tag#174 CDB: Write same(16) 93 08 00
00 00 00 00 07 ff f8 00 00 ff ff 00 00
[ 29.466695] critical target error, dev sda, sector 524280 op
0x3:(DISCARD) flags 0x4800 phys_seg 1 prio class 0
[ 29.468364] sd 0:0:0:0: [sda] tag#175 FAILED Result:
hostbyte=DID_OK driverbyte=DRIVER_OK cmd_age=0s
[ 29.469774] sd 0:0:0:0: [sda] tag#175 Sense Key : Illegal Request
[current]
[ 29.470890] sd 0:0:0:0: [sda] tag#175 Add. Sense: Invalid field in cdb
[ 29.471867] sd 0:0:0:0: [sda] tag#175 CDB: Write same(16) 93 08 00
00 00 00 00 08 ff f7 00 00 ff ff 00 00
[ 29.473323] critical target error, dev sda, sector 589815 op
0x3:(DISCARD) flags 0x4800 phys_seg 1 prio class 0
#
#
next prev parent reply other threads:[~2024-08-16 8:22 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-12 14:49 [REGRESSION] critical target error, bisected Chris Bainbridge
2024-08-13 2:09 ` Martin K. Petersen
2024-08-13 2:21 ` Martin K. Petersen
2024-08-16 3:56 ` Martin K. Petersen
2024-08-16 6:08 ` Chris Bainbridge
2024-08-16 7:59 ` Shinichiro Kawasaki
2024-08-16 8:06 ` hch
2024-08-17 0:51 ` Martin K. Petersen
2024-08-16 8:21 ` John Garry [this message]
2024-08-17 0:53 ` [PATCH] scsi: sd: Do not attempt to configure discard unless LBPME is set Martin K. Petersen
2024-08-17 1:28 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1c03c6bb-b05b-4052-8a75-c062ce3af28e@oracle.com \
--to=john.g.garry@oracle.com \
--cc=axboe@kernel.dk \
--cc=chris.bainbridge@gmail.com \
--cc=fengli@smartx.com \
--cc=hch@lst.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox