From: Bart Van Assche <bvanassche@acm.org>
To: Yang Erkun <yangerkun@huawei.com>,
dgilbert@interlog.com, James.Bottomley@HansenPartnership.com,
martin.petersen@oracle.com, linux-scsi@vger.kernel.org
Cc: yangerkun@huaweicloud.com
Subject: Re: [PATCH 2/3] scsi: sg: Resolve soft lockup issue when opening /dev/sgX
Date: Mon, 26 Jan 2026 09:04:50 -0800 [thread overview]
Message-ID: <1f5708a2-b00a-4be1-a005-c5137ce5863b@acm.org> (raw)
In-Reply-To: <20260126132745.1830629-3-yangerkun@huawei.com>
On 1/26/26 5:27 AM, Yang Erkun wrote:
> + /* limit "big buff" to 1 MB */
> + if (size < 0 || size > 1048576)
> + return -ERANGE;
Why 1 MB? Please explain this in the patch description.
Thanks,
Bart.
next prev parent reply other threads:[~2026-01-26 17:04 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-26 13:27 [PATCH 0/3] scsi: sg: minor bugfix and cleanup Yang Erkun
2026-01-26 13:27 ` [PATCH 1/3] scsi: sg: Fix sysctl sg-big-buff register during sg_init Yang Erkun
2026-01-26 16:45 ` Bart Van Assche
2026-01-26 13:27 ` [PATCH 2/3] scsi: sg: Resolve soft lockup issue when opening /dev/sgX Yang Erkun
2026-01-26 17:04 ` Bart Van Assche [this message]
2026-01-27 1:28 ` yangerkun
2026-01-26 13:27 ` [PATCH 3/3] scsi: sg: Remove deprecated sg-big-buff Yang Erkun
2026-01-26 17:06 ` Bart Van Assche
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1f5708a2-b00a-4be1-a005-c5137ce5863b@acm.org \
--to=bvanassche@acm.org \
--cc=James.Bottomley@HansenPartnership.com \
--cc=dgilbert@interlog.com \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=yangerkun@huawei.com \
--cc=yangerkun@huaweicloud.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox