From: "Peter Wang (王信友)" <peter.wang@mediatek.com>
To: "bvanassche@acm.org" <bvanassche@acm.org>,
"martin.petersen@oracle.com" <martin.petersen@oracle.com>
Cc: "linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
"beanhuo@micron.com" <beanhuo@micron.com>,
"mani@kernel.org" <mani@kernel.org>,
"avri.altman@sandisk.com" <avri.altman@sandisk.com>,
"James.Bottomley@HansenPartnership.com"
<James.Bottomley@HansenPartnership.com>,
"quic_nguyenb@quicinc.com" <quic_nguyenb@quicinc.com>,
"adrian.hunter@intel.com" <adrian.hunter@intel.com>
Subject: Re: [PATCH] ufs: core: Improve IOPS
Date: Fri, 15 Aug 2025 06:21:29 +0000 [thread overview]
Message-ID: <1f67bcc9c93101260223dcc6e7844f07d463e4a8.camel@mediatek.com> (raw)
In-Reply-To: <bf5ee29b-bd7c-4fd6-a558-eba0b9c09fa4@acm.org>
On Thu, 2025-08-14 at 08:48 -0700, Bart Van Assche wrote:
> On 8/14/25 1:28 AM, Peter Wang (王信友) wrote:
> > Although this may not cause any errors, it is clearly a
> > coding defect that impacts performance.
> > Have you considered adding a "Fixes" and "Cc" tag to
> > address this issue?
>
> Hi Peter,
>
> My understanding is that the "Fixes" tag is reserved for bug fixes
> and
> also that it should not be used for performance improvements unless
> if
> the patch fixes a performance regression. I think this patch is a
> performance improvement and not a performance regression fix. Hence,
> the
> "Fixes" tag should not be used. However, if someone wants to submit
> this
> patch for inclusion in an Android kernel, I will be happy to support
> that effort.
>
> Bart.
Got it, thanks.
Reviewed-by: Peter Wang <peter.wang@mediatek.com>
next prev parent reply other threads:[~2025-08-15 6:21 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-13 17:10 [PATCH] ufs: core: Improve IOPS Bart Van Assche
2025-08-14 8:28 ` Peter Wang (王信友)
2025-08-14 15:48 ` Bart Van Assche
2025-08-15 6:21 ` Peter Wang (王信友) [this message]
2025-08-14 9:02 ` Bean Huo
2025-08-19 2:00 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1f67bcc9c93101260223dcc6e7844f07d463e4a8.camel@mediatek.com \
--to=peter.wang@mediatek.com \
--cc=James.Bottomley@HansenPartnership.com \
--cc=adrian.hunter@intel.com \
--cc=avri.altman@sandisk.com \
--cc=beanhuo@micron.com \
--cc=bvanassche@acm.org \
--cc=linux-scsi@vger.kernel.org \
--cc=mani@kernel.org \
--cc=martin.petersen@oracle.com \
--cc=quic_nguyenb@quicinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox