Re: [PATCH] sd.c fixes applied incorectly to 2.4.19-preXX

James Bottomley
2002-04-15T20:51:24Z

gibbs@scsiguy.com said:
> Looking at the latest version of your tree via bitkeeper, it seems
> that the wrong patch has been applied to sd.c. In its current state,
> the disk driver will fail to act upon any sense data returned by the
> low level controller. The following patch restores correct behavior.

Actually, this should be using the scsi_sense_valid() function call in
scsi_error.c, shouldn't it? Especially since the criterion for valid sense is
merely that bit 7 be set with the error code (which can be either 0x70 or
0x71) in bits 0-6.

James