RE: [PATCH] sd.c fixes applied incorectly to 2.4.19-preXX

Tony Battersby
2002-04-16T15:25:06Z

> > If you insist on doing this, lets at least preserve the current
> > behavior:
>
> > /*
> > * FIXME: this driver treats deferred errors are fatal for
> [...]
> > if (scsi_sense_valid(SCpnt)
> > && scsi_sense_key(SCpnt) == SKEY_CURRENT_ERROR) {
>
> Excellent! It's a lot more readable for people not versed in
> sense buffer
> layout, thanks!

Why are you calling it the sense key? Current vs. deferred error is
indicated by the error code (sense_data[0] & 0x7f), not the sense key
(sense_data[2] & 0x0f). Calling it the sense key may lead to confusion for
those who are versed in sense buffer layout.

Tony