Question on drivers/scsi/scsi_error.c

Question on drivers/scsi/scsi_error.c

[michael]

Hello,

why does scsi_check_sense return SUCCESS on e.g. HARDWARE_ERRORs?

        case ILLEGAL_REQUEST:
        case BLANK_CHECK:
        case DATA_PROTECT:
        case HARDWARE_ERROR:
        default:
                return SUCCESS;

I think that those errors should return FAILED, but I may overlook
something.  Please send Cc: to me, as I am not subscribed to the list.

Michael

Re: Question on drivers/scsi/scsi_error.c

[Doug Ledford]

On Tue, May 21, 2002 at 02:31:14PM -0000, michael@freenet-ag.de wrote:
> Hello,
> 
> why does scsi_check_sense return SUCCESS on e.g. HARDWARE_ERRORs?
> 
>         case ILLEGAL_REQUEST:
>         case BLANK_CHECK:
>         case DATA_PROTECT:
>         case HARDWARE_ERROR:
>         default:
>                 return SUCCESS;
> 
> I think that those errors should return FAILED, but I may overlook
> something.  Please send Cc: to me, as I am not subscribed to the list.

Because returning SUCCESS from scsi_check_sense causes the command to be 
sent back to the upper layers as completed, where the sd layer can then 
remap the command to get around the hardware error if it so chooses and 
then send a new command back down.

-- 
  Doug Ledford <dledford@redhat.com>     919-754-3700 x44233
         Red Hat, Inc. 
         1801 Varsity Dr.
         Raleigh, NC 27606